You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 22:32:59 UTC

[GitHub] [arrow] wjones127 commented on a change in pull request #12339: ARROW-14908: [C++][R] Dataset hash join segfaults on Windows [WIP]

wjones127 commented on a change in pull request #12339:
URL: https://github.com/apache/arrow/pull/12339#discussion_r803145529



##########
File path: cpp/src/arrow/compute/exec/hash_join.cc
##########
@@ -151,6 +151,7 @@ class HashJoinBasicImpl : public HashJoinImpl {
   }
 
   void InitLocalStateIfNeeded(size_t thread_index) {
+    DCHECK_LT(thread_index, local_states_.size());
     ThreadLocalState& local_state = local_states_[thread_index];

Review comment:
       So far I've found that this DCHECK is not passing. So either we are missing a `ThreadLocalState` or the thread_index being passed is wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org