You are viewing a plain text version of this content. The canonical link for it is here.
Posted to site-dev@james.apache.org by rd...@apache.org on 2009/09/05 11:50:18 UTC
svn commit: r811613 [25/48] - in /james/site/trunk/www/jsieve: ./ apidocs/
apidocs/org/apache/jsieve/ apidocs/org/apache/jsieve/class-use/
apidocs/org/apache/jsieve/commands/
apidocs/org/apache/jsieve/commands/class-use/
apidocs/org/apache/jsieve/comma...
Modified: james/site/trunk/www/jsieve/main/pmd.xml
URL: http://svn.apache.org/viewvc/james/site/trunk/www/jsieve/main/pmd.xml?rev=811613&r1=811612&r2=811613&view=diff
==============================================================================
--- james/site/trunk/www/jsieve/main/pmd.xml (original)
+++ james/site/trunk/www/jsieve/main/pmd.xml Sat Sep 5 09:49:32 2009
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<pmd version="4.2.2" timestamp="2009-04-11T20:04:25.064">
+<pmd version="4.2.2" timestamp="2009-09-05T10:19:20.017">
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/Argument.java">
<violation beginline="33" endline="33" begincolumn="12" endcolumn="29" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="Argument" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
@@ -20,12 +20,12 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/BaseSieveContext.java">
-<violation beginline="47" endline="56" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.jsieve" class="BaseSieveContext" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3">
+<violation beginline="44" endline="53" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.jsieve" class="BaseSieveContext" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3">
It is a good practice to call super() in a constructor
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/Command.java">
-<violation beginline="157" endline="157" begincolumn="9" endcolumn="74" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Command" method="execute" variable="executable" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="157" endline="157" begincolumn="9" endcolumn="94" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Command" method="execute" variable="executable" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
<violation beginline="158" endline="159" begincolumn="9" endcolumn="36" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Command" method="execute" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
@@ -33,50 +33,84 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/CommandManager.java">
-<violation beginline="40" endline="40" begincolumn="12" endcolumn="76" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="41" endline="41" begincolumn="12" endcolumn="76" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="50" endline="50" begincolumn="12" endcolumn="51" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="51" endline="51" begincolumn="12" endcolumn="51" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/CommandManagerImpl.java">
-<violation beginline="52" endline="54" begincolumn="13" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="lookup" variable="cmdClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'cmdClass' (lines '52'-'54').
+<violation beginline="56" endline="58" begincolumn="13" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="lookup" variable="cmdClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'cmdClass' (lines '56'-'58').
</violation>
-<violation beginline="54" endline="63" begincolumn="13" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="lookup" variable="cmdClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'cmdClass' (lines '54'-'63').
+<violation beginline="58" endline="67" begincolumn="13" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="lookup" variable="cmdClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'cmdClass' (lines '58'-'67').
</violation>
-<violation beginline="95" endline="98" begincolumn="13" endcolumn="30" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="isCommandSupported" variable="isSupported" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'isSupported' (lines '95'-'98').
+<violation beginline="99" endline="102" begincolumn="13" endcolumn="30" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="isCommandSupported" variable="isSupported" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'isSupported' (lines '99'-'102').
</violation>
-<violation beginline="99" endline="100" begincolumn="11" endcolumn="9" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="isCommandSupported" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3">
+<violation beginline="103" endline="104" begincolumn="11" endcolumn="9" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="isCommandSupported" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3">
Avoid empty catch blocks
</violation>
-<violation beginline="116" endline="116" begincolumn="9" endcolumn="78" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="getClassName" variable="className" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="120" endline="120" begincolumn="9" endcolumn="69" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="CommandManagerImpl" method="getClassName" variable="className" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
</file>
+<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/Commands.java">
+<violation beginline="84" endline="84" begincolumn="10" endcolumn="10" rule="EmptyStatementNotInLoop" ruleset="Basic Rules" package="org.apache.jsieve" class="Commands" method="execute" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyStatementNotInLoop" priority="3">
+An empty statement (semicolon) not part of a loop
+</violation>
+</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/ComparatorManager.java">
-<violation beginline="41" endline="41" begincolumn="12" endcolumn="72" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="42" endline="42" begincolumn="12" endcolumn="72" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+Avoid modifiers which are implied by the context
+</violation>
+<violation beginline="51" endline="51" begincolumn="12" endcolumn="69" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+Avoid modifiers which are implied by the context
+</violation>
+<violation beginline="58" endline="58" begincolumn="12" endcolumn="44" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/ComparatorManagerImpl.java">
-<violation beginline="53" endline="55" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManagerImpl" method="lookup" variable="comparatorClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'comparatorClass' (lines '53'-'55').
+<violation beginline="46" endline="46" begincolumn="9" endcolumn="85" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManagerImpl" method="standardDefinedComparators" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="55" endline="65" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManagerImpl" method="lookup" variable="comparatorClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'comparatorClass' (lines '55'-'65').
+<violation beginline="100" endline="102" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManagerImpl" method="lookup" variable="comparatorClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'comparatorClass' (lines '100'-'102').
+</violation>
+<violation beginline="102" endline="112" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManagerImpl" method="lookup" variable="comparatorClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'comparatorClass' (lines '102'-'112').
+</violation>
+<violation beginline="160" endline="160" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.jsieve" class="ComparatorManagerImpl" method="isSupported" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3">
+A method should have only one exit point, and that should be the last statement in the method
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/ConfigurationManager.java">
-<violation beginline="110" endline="115" begincolumn="13" endcolumn="71" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="getConfigStream" variable="stream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'stream' (lines '110'-'115').
+<violation beginline="158" endline="163" begincolumn="13" endcolumn="71" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="getConfigStream" variable="stream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'stream' (lines '158'-'163').
</violation>
-<violation beginline="112" endline="113" begincolumn="9" endcolumn="40" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="getConfigStream" variable="contextClassLoader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="160" endline="161" begincolumn="9" endcolumn="40" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="getConfigStream" variable="contextClassLoader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
+<violation beginline="231" endline="231" begincolumn="9" endcolumn="58" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="loadConfiguration" variable="properties" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="232" endline="233" begincolumn="9" endcolumn="99" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="loadConfiguration" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="241" endline="241" begincolumn="9" endcolumn="52" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="loadProperties" variable="is" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="242" endline="242" begincolumn="9" endcolumn="45" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ConfigurationManager" method="loadProperties" variable="p" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+</file>
+<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/Constants.java">
+<violation beginline="21" endline="35" begincolumn="8" endcolumn="1" rule="AtLeastOneConstructor" ruleset="Controversial Rules" package="org.apache.jsieve" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AtLeastOneConstructor" priority="3">
+Each class should declare at least one constructor
+</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/Executable.java">
<violation beginline="29" endline="30" begincolumn="12" endcolumn="34" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="Executable" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
@@ -121,88 +155,112 @@
<violation beginline="137" endline="137" begincolumn="9" endcolumn="73" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ScriptCoordinate" method="commandException" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="151" endline="151" begincolumn="9" endcolumn="33" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ScriptCoordinate" method="addStartLineAndColumn" variable="buffer" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="151" endline="151" begincolumn="9" endcolumn="34" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="ScriptCoordinate" method="addStartLineAndColumn" variable="buffer" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/SieveFactory.java">
-<violation beginline="96" endline="97" begincolumn="13" endcolumn="28" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveFactory" method="parse" variable="node" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="101" endline="102" begincolumn="13" endcolumn="28" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveFactory" method="parse" variable="node" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="144" endline="145" begincolumn="9" endcolumn="52" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveFactory" method="evaluate" variable="context" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="146" endline="148" begincolumn="11" endcolumn="9" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.jsieve" class="SieveFactory" method="evaluate" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3">
+<violation beginline="155" endline="157" begincolumn="15" endcolumn="13" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.jsieve" class="SieveFactory" method="evaluate" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3">
Avoid empty catch blocks
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/SieveParserVisitorImpl.java">
-<violation beginline="97" endline="109" begincolumn="14" endcolumn="63" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'children' (lines '97'-'109').
+<violation beginline="99" endline="111" begincolumn="22" endcolumn="79" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'children' (lines '99'-'111').
</violation>
-<violation beginline="98" endline="101" begincolumn="13" endcolumn="49" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="argument" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'argument' (lines '98'-'101').
+<violation beginline="100" endline="103" begincolumn="13" endcolumn="49" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="argument" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'argument' (lines '100'-'103').
</violation>
-<violation beginline="98" endline="103" begincolumn="13" endcolumn="31" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="argument" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'argument' (lines '98'-'103').
+<violation beginline="100" endline="105" begincolumn="13" endcolumn="31" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="argument" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'argument' (lines '100'-'105').
</violation>
-<violation beginline="115" endline="116" begincolumn="9" endcolumn="63" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'children' (lines '115'-'116').
+<violation beginline="118" endline="119" begincolumn="9" endcolumn="63" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'children' (lines '118'-'119').
</violation>
-<violation beginline="120" endline="125" begincolumn="17" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'testList' (lines '120'-'125').
+<violation beginline="123" endline="128" begincolumn="17" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'testList' (lines '123'-'128').
</violation>
-<violation beginline="120" endline="127" begincolumn="17" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'testList' (lines '120'-'127').
+<violation beginline="123" endline="130" begincolumn="17" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'testList' (lines '123'-'130').
</violation>
-<violation beginline="125" endline="125" begincolumn="17" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'testList' (lines '125'-'125').
+<violation beginline="128" endline="128" begincolumn="17" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'testList' (lines '128'-'128').
</violation>
-<violation beginline="125" endline="127" begincolumn="17" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'testList' (lines '125'-'127').
+<violation beginline="128" endline="130" begincolumn="17" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'testList' (lines '128'-'130').
</violation>
-<violation beginline="127" endline="125" begincolumn="17" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'testList' (lines '127'-'125').
+<violation beginline="130" endline="128" begincolumn="17" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'testList' (lines '130'-'128').
</violation>
-<violation beginline="127" endline="127" begincolumn="17" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'testList' (lines '127'-'127').
+<violation beginline="130" endline="130" begincolumn="17" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="testList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'testList' (lines '130'-'130').
</violation>
-<violation beginline="155" endline="156" begincolumn="9" endcolumn="63" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'children' (lines '155'-'156').
+<violation beginline="163" endline="164" begincolumn="9" endcolumn="63" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'children' (lines '163'-'164').
</violation>
-<violation beginline="160" endline="165" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'arguments' (lines '160'-'165').
+<violation beginline="168" endline="173" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'arguments' (lines '168'-'173').
</violation>
-<violation beginline="161" endline="167" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="block" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'block' (lines '161'-'167').
+<violation beginline="169" endline="175" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="block" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'block' (lines '169'-'175').
</violation>
-<violation beginline="165" endline="165" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'arguments' (lines '165'-'165').
+<violation beginline="173" endline="173" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'arguments' (lines '173'-'173').
</violation>
-<violation beginline="167" endline="167" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="block" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'block' (lines '167'-'167').
+<violation beginline="175" endline="175" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="block" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'block' (lines '175'-'175').
</violation>
-<violation beginline="171" endline="171" begincolumn="9" endcolumn="67" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="coordinate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="179" endline="179" begincolumn="9" endcolumn="67" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="coordinate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="224" endline="224" begincolumn="9" endcolumn="53" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="234" endline="234" begincolumn="9" endcolumn="53" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="246" endline="247" begincolumn="9" endcolumn="63" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'children' (lines '246'-'247').
+<violation beginline="258" endline="259" begincolumn="9" endcolumn="63" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="children" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'children' (lines '258'-'259').
</violation>
-<violation beginline="251" endline="255" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'arguments' (lines '251'-'255').
+<violation beginline="263" endline="267" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'arguments' (lines '263'-'267').
</violation>
-<violation beginline="255" endline="255" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'arguments' (lines '255'-'255').
+<violation beginline="267" endline="267" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveParserVisitorImpl" method="visit" variable="arguments" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'arguments' (lines '267'-'267').
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/SieveValidationVisitor.java">
-<violation beginline="81" endline="81" begincolumn="9" endcolumn="42" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="visit" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="94" endline="94" begincolumn="9" endcolumn="42" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="visit" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="121" endline="121" begincolumn="9" endcolumn="44" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="visit" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="120" endline="120" begincolumn="13" endcolumn="48" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="visit" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="130" endline="130" begincolumn="17" endcolumn="59" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="visit" variable="tag" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="122" endline="122" begincolumn="17" endcolumn="50" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="visit" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="136" endline="136" begincolumn="9" endcolumn="51" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="visit" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="160" endline="160" begincolumn="9" endcolumn="44" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="comparatorNameArgument" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="162" endline="162" begincolumn="13" endcolumn="46" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="comparatorNameArgument" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="165" endline="168" begincolumn="17" endcolumn="17" rule="CollapsibleIfStatements" ruleset="Basic Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="comparatorNameArgument" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements" priority="3">
+These nested if statements could be combined
+</violation>
+<violation beginline="174" endline="174" begincolumn="9" endcolumn="44" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="requirements" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="176" endline="176" begincolumn="13" endcolumn="46" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="requirements" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="178" endline="178" begincolumn="17" endcolumn="86" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="SieveValidationVisitor" method="requirements" variable="comparatorName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
</file>
@@ -221,42 +279,45 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/Test.java">
-<violation beginline="51" endline="51" begincolumn="9" endcolumn="37" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Test" method="execute" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
-Avoid using final local variables, turn them into fields
+<violation beginline="48" endline="48" begincolumn="16" endcolumn="55" rule="BooleanInstantiation" ruleset="Basic Rules" package="org.apache.jsieve" class="Test" method="execute" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#BooleanInstantiation" priority="2">
+Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.
</violation>
-<violation beginline="52" endline="52" begincolumn="9" endcolumn="57" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Test" method="execute" variable="test" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="64" endline="64" begincolumn="9" endcolumn="37" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Test" method="isTestPassed" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="53" endline="53" begincolumn="9" endcolumn="74" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Test" method="execute" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="65" endline="65" begincolumn="9" endcolumn="74" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="Test" method="isTestPassed" variable="test" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="54" endline="54" begincolumn="16" endcolumn="34" rule="BooleanInstantiation" ruleset="Basic Rules" package="org.apache.jsieve" class="Test" method="execute" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#BooleanInstantiation" priority="2">
-Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.
-</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/TestList.java">
-<violation beginline="85" endline="85" begincolumn="16" endcolumn="34" rule="BooleanInstantiation" ruleset="Basic Rules" package="org.apache.jsieve" class="TestList" method="execute" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#BooleanInstantiation" priority="2">
+<violation beginline="77" endline="77" begincolumn="16" endcolumn="55" rule="BooleanInstantiation" ruleset="Basic Rules" package="org.apache.jsieve" class="TestList" method="execute" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#BooleanInstantiation" priority="2">
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.
</violation>
+<violation beginline="90" endline="92" begincolumn="13" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestList" method="allTestsPass" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'result' (lines '90'-'92').
+</violation>
+<violation beginline="110" endline="112" begincolumn="13" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestList" method="anyTestsPass" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'result' (lines '110'-'112').
+</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/TestManager.java">
-<violation beginline="41" endline="41" begincolumn="12" endcolumn="70" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="42" endline="42" begincolumn="12" endcolumn="70" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/TestManagerImpl.java">
-<violation beginline="54" endline="57" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManagerImpl" method="lookup" variable="testClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'testClass' (lines '54'-'57').
+<violation beginline="57" endline="60" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManagerImpl" method="lookup" variable="testClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'testClass' (lines '57'-'60').
</violation>
-<violation beginline="57" endline="66" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManagerImpl" method="lookup" variable="testClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'testClass' (lines '57'-'66').
+<violation beginline="60" endline="69" begincolumn="13" endcolumn="39" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManagerImpl" method="lookup" variable="testClass" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'testClass' (lines '60'-'69').
</violation>
-<violation beginline="101" endline="101" begincolumn="9" endcolumn="78" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManagerImpl" method="getClassName" variable="className" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="104" endline="104" begincolumn="9" endcolumn="69" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve" class="TestManagerImpl" method="getClassName" variable="className" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/AbstractActionCommand.java">
-<violation beginline="39" endline="41" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="AbstractActionCommand" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
+<violation beginline="40" endline="42" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="AbstractActionCommand" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
</file>
@@ -274,8 +335,8 @@
<violation beginline="38" endline="40" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="AbstractConditionalCommand" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
-<violation beginline="56" endline="67" begincolumn="26" endcolumn="67" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="AbstractConditionalCommand" method="execute" variable="oldManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'oldManager' (lines '56'-'67').
+<violation beginline="55" endline="66" begincolumn="26" endcolumn="67" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="AbstractConditionalCommand" method="execute" variable="oldManager" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'oldManager' (lines '55'-'66').
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/AbstractControlCommand.java">
@@ -310,12 +371,15 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/If.java">
-<violation beginline="36" endline="38" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="If" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
+<violation beginline="35" endline="37" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="If" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
-<violation beginline="61" endline="61" begincolumn="13" endcolumn="33" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="If" method="executeBasic" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3">
+<violation beginline="60" endline="60" begincolumn="13" endcolumn="33" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="If" method="executeBasic" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3">
A method should have only one exit point, and that should be the last statement in the method
</violation>
+<violation beginline="63" endline="63" begincolumn="9" endcolumn="87" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="If" method="executeBasic" variable="isTestPassed" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/Keep.java">
<violation beginline="37" endline="39" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="Keep" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
@@ -328,10 +392,16 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/Require.java">
-<violation beginline="43" endline="45" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="Require" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
+<violation beginline="46" endline="48" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="Require" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
-<violation beginline="85" endline="87" begincolumn="11" endcolumn="9" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.jsieve.commands" class="Require" method="validateFeature" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3">
+<violation beginline="63" endline="64" begincolumn="9" endcolumn="68" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="Require" method="executeBasic" variable="stringArgumentList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="83" endline="83" begincolumn="13" endcolumn="82" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands" class="Require" method="validateFeature" variable="comparatorName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="93" endline="95" begincolumn="15" endcolumn="13" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.jsieve.commands" class="Require" method="validateFeature" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3">
Avoid empty catch blocks
</violation>
</file>
@@ -341,20 +411,32 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/extensions/Log.java">
-<violation beginline="49" endline="51" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
+<violation beginline="57" endline="59" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
-<violation beginline="59" endline="111" begincolumn="16" endcolumn="30" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="logLevel" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'logLevel' (lines '59'-'111').
+<violation beginline="67" endline="119" begincolumn="16" endcolumn="30" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="logLevel" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'logLevel' (lines '67'-'119').
</violation>
-<violation beginline="60" endline="97" begincolumn="21" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'message' (lines '60'-'97').
+<violation beginline="68" endline="105" begincolumn="21" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'message' (lines '68'-'105').
</violation>
-<violation beginline="60" endline="111" begincolumn="16" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'message' (lines '60'-'111').
+<violation beginline="68" endline="119" begincolumn="16" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'message' (lines '68'-'119').
</violation>
-<violation beginline="80" endline="111" begincolumn="21" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="logLevel" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'logLevel' (lines '80'-'111').
+<violation beginline="73" endline="73" begincolumn="9" endcolumn="95" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="argumentsIter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="78" endline="78" begincolumn="13" endcolumn="58" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="argument" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="80" endline="80" begincolumn="17" endcolumn="68" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="tag" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="88" endline="119" begincolumn="21" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="logLevel" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'logLevel' (lines '88'-'119').
+</violation>
+<violation beginline="101" endline="101" begincolumn="13" endcolumn="58" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands.extensions" class="Log" method="executeBasic" variable="argument" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/extensions/LogLevelTags.java">
@@ -378,23 +460,26 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/optional/FileInto.java">
-<violation beginline="43" endline="45" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
+<violation beginline="41" endline="43" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
-<violation beginline="63" endline="81" begincolumn="16" endcolumn="59" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" method="executeBasic" variable="destination" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DU'-anomaly for variable 'destination' (lines '63'-'81').
+<violation beginline="61" endline="62" begincolumn="9" endcolumn="59" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" method="executeBasic" variable="destination" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="69" endline="72" begincolumn="13" endcolumn="49" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" method="executeBasic" variable="isDuplicate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'isDuplicate' (lines '69'-'72').
+<violation beginline="61" endline="80" begincolumn="22" endcolumn="59" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" method="executeBasic" variable="destination" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DU'-anomaly for variable 'destination' (lines '61'-'80').
</violation>
-<violation beginline="72" endline="72" begincolumn="13" endcolumn="49" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" method="executeBasic" variable="isDuplicate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'isDuplicate' (lines '72'-'72').
+<violation beginline="66" endline="68" begincolumn="13" endcolumn="49" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="FileInto" method="executeBasic" variable="isDuplicate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'isDuplicate' (lines '66'-'68').
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/commands/optional/Reject.java">
<violation beginline="50" endline="52" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="Reject" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
+<violation beginline="67" endline="68" begincolumn="9" endcolumn="59" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.commands.optional" class="Reject" method="executeBasic" variable="message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/comparators/AsciiCasemap.java">
<violation beginline="35" endline="37" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiCasemap" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
@@ -402,9 +487,30 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/comparators/AsciiNumeric.java">
-<violation beginline="33" endline="35" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
+<violation beginline="35" endline="37" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
+<violation beginline="43" endline="43" begincolumn="9" endcolumn="28" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" method="equals" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="54" endline="54" begincolumn="17" endcolumn="62" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" method="equals" variable="integer1" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="55" endline="55" begincolumn="17" endcolumn="62" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" method="equals" variable="integer2" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="65" endline="65" begincolumn="13" endcolumn="45" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" method="toInteger" variable="next" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="70" endline="70" begincolumn="9" endcolumn="70" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" method="toInteger" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="82" endline="82" begincolumn="8" endcolumn="52" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" method="isPositiveInfinity" variable="initialCharacter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+<violation beginline="83" endline="83" begincolumn="8" endcolumn="56" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="AsciiNumeric" method="isPositiveInfinity" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/comparators/ComparatorNames.java">
<violation beginline="27" endline="27" begincolumn="25" endcolumn="60" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorNames" variable="OCTET_COMPARATOR" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
@@ -415,14 +521,14 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/comparators/ComparatorUtils.java">
-<violation beginline="60" endline="62" begincolumn="13" endcolumn="79" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorUtils" method="match" variable="isMatched" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'isMatched' (lines '60'-'62').
+<violation beginline="61" endline="63" begincolumn="13" endcolumn="79" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorUtils" method="match" variable="isMatched" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'isMatched' (lines '61'-'63').
</violation>
-<violation beginline="60" endline="64" begincolumn="13" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorUtils" method="match" variable="isMatched" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'isMatched' (lines '60'-'64').
+<violation beginline="61" endline="65" begincolumn="13" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorUtils" method="match" variable="isMatched" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'isMatched' (lines '61'-'65').
</violation>
-<violation beginline="60" endline="67" begincolumn="13" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorUtils" method="match" variable="isMatched" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
-Found 'DD'-anomaly for variable 'isMatched' (lines '60'-'67').
+<violation beginline="61" endline="68" begincolumn="13" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorUtils" method="match" variable="isMatched" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5">
+Found 'DD'-anomaly for variable 'isMatched' (lines '61'-'68').
</violation>
<violation beginline="88" endline="88" begincolumn="13" endcolumn="74" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="ComparatorUtils" method="matches" variable="matcher" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
@@ -444,7 +550,7 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/comparators/Contains.java">
-<violation beginline="36" endline="36" begincolumn="12" endcolumn="62" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="Contains" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="40" endline="40" begincolumn="12" endcolumn="86" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.comparators" class="Contains" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
</file>
@@ -480,54 +586,62 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/mail/MailAdapter.java">
-<violation beginline="80" endline="80" begincolumn="12" endcolumn="29" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="86" endline="86" begincolumn="12" endcolumn="49" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="89" endline="89" begincolumn="12" endcolumn="45" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="95" endline="95" begincolumn="12" endcolumn="37" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="101" endline="101" begincolumn="12" endcolumn="65" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="107" endline="107" begincolumn="12" endcolumn="73" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="122" endline="122" begincolumn="12" endcolumn="73" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="128" endline="128" begincolumn="12" endcolumn="81" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="132" endline="132" begincolumn="12" endcolumn="59" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="138" endline="138" begincolumn="12" endcolumn="67" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="140" endline="140" begincolumn="12" endcolumn="41" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="146" endline="146" begincolumn="12" endcolumn="41" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="145" endline="145" begincolumn="12" endcolumn="55" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="151" endline="151" begincolumn="12" endcolumn="55" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="162" endline="162" begincolumn="12" endcolumn="61" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="168" endline="168" begincolumn="12" endcolumn="61" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="173" endline="173" begincolumn="12" endcolumn="57" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="178" endline="178" begincolumn="12" endcolumn="94" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="198" endline="199" begincolumn="12" endcolumn="64" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="203" endline="204" begincolumn="12" endcolumn="64" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="204" endline="221" begincolumn="12" endcolumn="5" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="209" endline="226" begincolumn="12" endcolumn="5" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="212" endline="212" begincolumn="16" endcolumn="37" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter$Address" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="217" endline="217" begincolumn="16" endcolumn="37" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter$Address" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="220" endline="220" begincolumn="16" endcolumn="34" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter$Address" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="225" endline="225" begincolumn="16" endcolumn="34" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailAdapter$Address" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
</file>
+<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/mail/MailUtils.java">
+<violation beginline="56" endline="56" begincolumn="40" endcolumn="40" rule="EmptyStatementNotInLoop" ruleset="Basic Rules" package="org.apache.jsieve.mail" class="MailUtils" method="getMatchingHeader" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyStatementNotInLoop" priority="3">
+An empty statement (semicolon) not part of a loop
+</violation>
+<violation beginline="57" endline="57" begincolumn="9" endcolumn="74" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.mail" class="MailUtils" method="getMatchingHeader" variable="matchedHeaderValues" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+Avoid using final local variables, turn them into fields
+</violation>
+</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/mail/optional/EnvelopeAccessors.java">
-<violation beginline="40" endline="40" begincolumn="12" endcolumn="67" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail.optional" class="EnvelopeAccessors" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="40" endline="40" begincolumn="12" endcolumn="75" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail.optional" class="EnvelopeAccessors" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="49" endline="49" begincolumn="12" endcolumn="61" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail.optional" class="EnvelopeAccessors" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="49" endline="49" begincolumn="12" endcolumn="69" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail.optional" class="EnvelopeAccessors" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
-<violation beginline="69" endline="69" begincolumn="12" endcolumn="75" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail.optional" class="EnvelopeAccessors" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
+<violation beginline="69" endline="69" begincolumn="12" endcolumn="83" rule="UnusedModifier" ruleset="Controversial Rules" package="org.apache.jsieve.mail.optional" class="EnvelopeAccessors" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnusedModifier" priority="3">
Avoid modifiers which are implied by the context
</violation>
</file>
@@ -550,7 +664,7 @@
<violation beginline="143" endline="144" begincolumn="9" endcolumn="61" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser" class="SieveNode" method="getCoordinate" variable="scriptCoordinate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="155" endline="155" begincolumn="9" endcolumn="51" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser" class="SieveNode" method="getPrecedingComments" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="155" endline="155" begincolumn="9" endcolumn="67" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser" class="SieveNode" method="getPrecedingComments" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
<violation beginline="159" endline="159" begincolumn="17" endcolumn="60" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser" class="SieveNode" method="getPrecedingComments" variable="comment" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
@@ -578,7 +692,7 @@
<violation beginline="73" endline="73" begincolumn="9" endcolumn="65" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser.address" class="SieveAddressBuilder" method="addAddresses" variable="reader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
-<violation beginline="84" endline="85" begincolumn="9" endcolumn="41" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser.address" class="SieveAddressBuilder" method="getAddresses" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
+<violation beginline="84" endline="84" begincolumn="9" endcolumn="80" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser.address" class="SieveAddressBuilder" method="getAddresses" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
Avoid using final local variables, turn them into fields
</violation>
<violation beginline="103" endline="103" begincolumn="13" endcolumn="57" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.jsieve.parser.address" class="SieveAddressBuilder$Worker" method="visit" variable="address" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3">
@@ -601,41 +715,47 @@
</violation>
</file>
<file name="/opt/development/workspace/jsieve/main/src/main/java/org/apache/jsieve/tests/AbstractCompatatorTest.java">
-<violation beginline="40" endline="42" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.tests" class="AbstractCompatatorTest" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
+<violation beginline="47" endline="49" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.jsieve.tests" class="AbstractCompatatorTest" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3">
Avoid unnecessary constructors - the compiler will generate these for you
</violation>
[... 336 lines stripped ...]