[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2923: [GOBBLIN-1083] Unit test improving & return failed when helix task cancelled

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2923: [GOBBLIN-1083] Unit test improving & return failed when helix task cancelled
URL: https://github.com/apache/incubator-gobblin/pull/2923#discussion_r404329650
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java
 ##########
 @@ -188,10 +192,10 @@ static void waitJobCompletion(HelixManager helixManager, String workFlowName, St
             // user requested cancellation, which is executed by executeCancellation()
             log.info("Job {} is cancelled, it will be deleted now.", jobName);
             HelixUtils.deleteStoppedHelixJob(helixManager, workFlowName, jobName);
-            return;
+            return false;
           case FAILED:
 
 Review comment:
   Based on the javadoc, shouldn't we return false for FAILED?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services