[GitHub] [qpid-proton] jiridanek commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #310:
URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618311040



##########
File path: cpp/include/proton/delivery.hpp
##########
@@ -64,6 +65,9 @@ class delivery : public transfer {
     /// Settle with MODIFIED state.
     PN_CPP_EXTERN void modify();
 
+    /// Return the tag for this delivery.
+    PN_CPP_EXTERN binary tag() const;

Review comment:
       You should rebase your PR branch on top of `main`, to get rid of this (already merged) code. Or you can just delete the commit from the branch; whichever you find simpler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org