You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/18 12:42:12 UTC
[GitHub] [airflow] potiuk opened a new pull request #9376: Fix in-breeze CLI tools to work also on Linux
potiuk opened a new pull request #9376:
URL: https://github.com/apache/airflow/pull/9376
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle merged pull request #9376: Fix in-breeze CLI tools to work also on Linux
Posted by GitBox <gi...@apache.org>.
feluelle merged pull request #9376:
URL: https://github.com/apache/airflow/pull/9376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9376: Fix in-breeze CLI tools to work also on Linux
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9376:
URL: https://github.com/apache/airflow/pull/9376#issuecomment-646181958
Seems Like all important ones passed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9376: Fix in-breeze CLI tools to work also on Linux
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9376:
URL: https://github.com/apache/airflow/pull/9376#discussion_r442202789
##########
File path: scripts/ci/run_cli_tool.sh
##########
@@ -157,12 +157,8 @@ RES=$?
# Set file permissions to the host user
if [[ "${HOST_OS}" == "Linux" ]]; then
- FIX_DOCKER_ARGS=(--rm)
- FIX_DOCKER_ARGS+=("${COMMON_DOCKER_ARGS[@]}")
- FIX_COMMAND=(bash -c
- "find ${DIRECTORIES_TO_FIX[@]@Q} -user root -print0 | xargs --null chown '${HOST_USER_ID}.${HOST_GROUP_ID}' --no-dereference")
-
- docker run "${FIX_DOCKER_ARGS[@]}" "${AIRFLOW_CI_IMAGE}" "${FIX_COMMAND[@]}" >/dev/null 2>&1
+ find "${DIRECTORIES_TO_FIX[@]}" -user root -print0 2>/dev/null | \
Review comment:
Docker is needed here to have access to the volume with credentials
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9376: Fix in-breeze CLI tools to work also on Linux
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9376:
URL: https://github.com/apache/airflow/pull/9376#discussion_r442289021
##########
File path: scripts/ci/run_cli_tool.sh
##########
@@ -157,12 +157,8 @@ RES=$?
# Set file permissions to the host user
if [[ "${HOST_OS}" == "Linux" ]]; then
- FIX_DOCKER_ARGS=(--rm)
- FIX_DOCKER_ARGS+=("${COMMON_DOCKER_ARGS[@]}")
- FIX_COMMAND=(bash -c
- "find ${DIRECTORIES_TO_FIX[@]@Q} -user root -print0 | xargs --null chown '${HOST_USER_ID}.${HOST_GROUP_ID}' --no-dereference")
-
- docker run "${FIX_DOCKER_ARGS[@]}" "${AIRFLOW_CI_IMAGE}" "${FIX_COMMAND[@]}" >/dev/null 2>&1
+ find "${DIRECTORIES_TO_FIX[@]}" -user root -print0 2>/dev/null | \
Review comment:
Correct. I simiplified it a bit and changed it to use the script we already had for that purpose. I also found out that we had another problem. "set +e" was missing so when the command failed, fixing ownership did not happen. I fixed that as well.
Pls. take a look @feluelle @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org