You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 14:00:57 UTC

[GitHub] [flink] leonardBang commented on pull request #12036: [FLINK-17537][connectors / jdbc] Refactor flink-jdbc connector structure

leonardBang commented on pull request #12036:
URL: https://github.com/apache/flink/pull/12036#issuecomment-625830095


   Thanks @faisalmoeen and @wuchong ‘s notes and comments.
   I'll update the PR soon.
   Hi, @fpompermaier For your first note about StreamITCase.clear() I‘ll skip too because FLIP-84 is not ready now(but should be soon). For the second note, this PR will try not to  modify JDBCDDialect.java and keep the PR clean and I think the JDBC Dialect need a better design too but not in this time(It will be a public API and need disscuss and design and even a FLIP from my unserstanding) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org