You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/03/17 21:17:27 UTC
[kudu-CR] [security] small re-factoring on TlsHandshake
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17193
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
[security] small re-factoring on TlsHandshake
A follow-up patch needs to know what side the TlsHandshake is running
at. This changelist introduces that piece of information into the
TlsHandshake class and also does other related re-factoring in the
related code.
Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_context.h
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/security/tls_handshake.h
M src/kudu/security/tls_socket-test.cc
8 files changed, 90 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/17193/1
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 )
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h
File src/kudu/security/tls_handshake.h:
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h@166
PS3, Line 166: // Data which is left pending in the write BIO after the last call to
: // Continue(), i.e. the data left pending after completing the TLS handshake.
: std::string rbio_pending_data_;
I might be missing something: is this used?
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc
File src/kudu/security/tls_handshake.cc:
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc@94
PS3, Line 94: ssl_ = std::move(s);
Not sure whether it'll make a functional difference, but would it make sense to only call this after both BIO_new() calls have succeeded?
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 17 Mar 2021 22:59:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17193
to look at the new patch set (#3).
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
[security] small re-factoring on TlsHandshake
A follow-up patch needs to know what side the TlsHandshake is running
at. This changelist introduces that piece of information into the
TlsHandshake class and also does other related re-factoring in the
related code.
Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_context.h
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/security/tls_handshake.h
M src/kudu/security/tls_socket-test.cc
8 files changed, 87 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/17193/3
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17193
to look at the new patch set (#2).
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
[security] small re-factoring on TlsHandshake
A follow-up patch needs to know what side the TlsHandshake is running
at. This changelist introduces that piece of information into the
TlsHandshake class and also does other related re-factoring in the
related code.
Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_context.h
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/security/tls_handshake.h
M src/kudu/security/tls_socket-test.cc
8 files changed, 89 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/17193/2
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 )
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 18 Mar 2021 15:02:49 +0000
Gerrit-HasComments: No
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17193
to look at the new patch set (#4).
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
[security] small re-factoring on TlsHandshake
A follow-up patch needs to know what side the TlsHandshake is running
at. This changelist introduces that piece of information into the
TlsHandshake class and also does other related re-factoring in the
related code.
Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_context.h
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/security/tls_handshake.h
M src/kudu/security/tls_socket-test.cc
8 files changed, 84 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/17193/4
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 )
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 18 Mar 2021 13:34:32 +0000
Gerrit-HasComments: No
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 )
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h
File src/kudu/security/tls_handshake.h:
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h@166
PS3, Line 166:
: } // namespace security
: } // namespace kudu
> I might be missing something: is this used?
Whoops: it's not used, indeed. Good catch!
It seems some extra stuff leaked from the follow-up patch :)
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc
File src/kudu/security/tls_handshake.cc:
http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc@94
PS3, Line 94: }
> Not sure whether it'll make a functional difference, but would it make sens
Well, at least it will be more consistent to allow for a retry calling Init() on the same object.
Done.
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 18 Mar 2021 01:15:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [security] small re-factoring on TlsHandshake
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17193 )
Change subject: [security] small re-factoring on TlsHandshake
......................................................................
[security] small re-factoring on TlsHandshake
A follow-up patch needs to know what side the TlsHandshake is running
at. This changelist introduces that piece of information into the
TlsHandshake class and also does other related re-factoring in the
related code.
Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Reviewed-on: http://gerrit.cloudera.org:8080/17193
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_context.h
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/security/tls_handshake.h
M src/kudu/security/tls_socket-test.cc
8 files changed, 84 insertions(+), 63 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e
Gerrit-Change-Number: 17193
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)