You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/02 19:06:32 UTC
[GitHub] [airflow] pbastia opened a new pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
pbastia opened a new pull request #12762:
URL: https://github.com/apache/airflow/pull/12762
closes: #12602
Refactors the `PodGenerator.construct_pod(..)` method to create kubernetes pods with `args` instead of `command`.
This allows the container's entrypoint to run, then call airflow with the proper arguments, instead of bypassing it altogether.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #12762:
URL: https://github.com/apache/airflow/pull/12762#issuecomment-773496080
Hi @pbastia, can you please rebase this PR? I can merge once that is done :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] matthieu-foucault commented on pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
matthieu-foucault commented on pull request #12762:
URL: https://github.com/apache/airflow/pull/12762#issuecomment-773499139
@dimberman didn't this get fixed in #12766 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
dimberman closed pull request #12762:
URL: https://github.com/apache/airflow/pull/12762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #12762:
URL: https://github.com/apache/airflow/pull/12762#issuecomment-773496080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12762:
URL: https://github.com/apache/airflow/pull/12762#issuecomment-737507536
[The Workflow run](https://github.com/apache/airflow/actions/runs/396967001) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12762:
URL: https://github.com/apache/airflow/pull/12762#issuecomment-737434340
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #12762:
URL: https://github.com/apache/airflow/pull/12762#issuecomment-773551294
@matthieu-foucault Doh! Thanks for catching that. Closing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] matthieu-foucault commented on pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
matthieu-foucault commented on pull request #12762:
URL: https://github.com/apache/airflow/pull/12762#issuecomment-773499139
@dimberman didn't this get fixed in #12766 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed pull request #12762: feat: PodGenerator.construct_pod uses k8s `args` instead of `command`
Posted by GitBox <gi...@apache.org>.
dimberman closed pull request #12762:
URL: https://github.com/apache/airflow/pull/12762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org