You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/07/04 07:54:24 UTC

[GitHub] spark pull request #21542: [SPARK-24529][Build][test-maven] Add spotbugs int...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21542#discussion_r200037280
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
    @@ -368,8 +368,7 @@ private[spark] class ExternalSorter[K, V, C](
         val bufferedIters = iterators.filter(_.hasNext).map(_.buffered)
         type Iter = BufferedIterator[Product2[K, C]]
         val heap = new mutable.PriorityQueue[Iter]()(new Ordering[Iter] {
    -      // Use the reverse of comparator.compare because PriorityQueue dequeues the max
    --- End diff --
    
    shall we keep this comment? we still use reverse order here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org