[GitHub] [kafka] lbradstreet edited a comment on pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

[GitBox <gi...@apache.org>]

lbradstreet edited a comment on pull request #10704:
URL: https://github.com/apache/kafka/pull/10704#issuecomment-849144204


   @ijuma I figured out the cause with some state change checks. The problem is that we're passing a recording map through to the channel/principal builders, and the recording map updates ignore. 
   ```
   	at org.apache.kafka.clients.producer.ProducerConfig.ignore(ProducerConfig.java:569)
   	at org.apache.kafka.common.config.AbstractConfig$RecordingMap.get(AbstractConfig.java:638)
   	at org.apache.kafka.common.network.ChannelBuilders.createPrincipalBuilder(ChannelBuilders.java:242)
   	at org.apache.kafka.common.network.PlaintextChannelBuilder$PlaintextAuthenticator.<init>(PlaintextChannelBuilder.java:96)
   	at org.apache.kafka.common.network.PlaintextChannelBuilder$PlaintextAuthenticator.<init>(PlaintextChannelBuilder.java:89)
   	at org.apache.kafka.common.network.PlaintextChannelBuilder.lambda$buildChannel$0(PlaintextChannelBuilder.java:66)
   	at org.apache.kafka.common.network.KafkaChannel.<init>(KafkaChannel.java:174)
   	at org.apache.kafka.common.network.KafkaChannel.<init>(KafkaChannel.java:164)
   	at org.apache.kafka.common.network.PlaintextChannelBuilder.buildChannel(PlaintextChannelBuilder.java:79)
   	at org.apache.kafka.common.network.PlaintextChannelBuilder.buildChannel(PlaintextChannelBuilder.java:67)
   	at org.apache.kafka.common.network.Selector.buildAndAttachKafkaChannel(Selector.java:356)
   	at org.apache.kafka.common.network.Selector.registerChannel(Selector.java:347)
   	at org.apache.kafka.common.network.Selector.connect(Selector.java:274)
   	at org.apache.kafka.clients.NetworkClient.initiateConnect(NetworkClient.java:1097)
   	at org.apache.kafka.clients.NetworkClient.access$700(NetworkClient.java:87)
   	at org.apache.kafka.clients.NetworkClient$DefaultMetadataUpdater.maybeUpdate(NetworkClient.java:1276)
   	at org.apache.kafka.clients.NetworkClient$DefaultMetadataUpdater.maybeUpdate(NetworkClient.java:1164)
   	at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:637)
   	at org.apache.kafka.clients.producer.internals.Sender.runOnce(Sender.java:327)
   	at org.apache.kafka.clients.producer.internals.Sender.run(Sender.java:242)
   ```
   
   If we're going to use these recording maps as we use them today I think this PR is a reasonable fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org