You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/10 18:37:08 UTC
[GitHub] [nifi] bbende opened a new pull request #4401: NIFI-7622 Use param context name from inside nested versioned PG when…
bbende opened a new pull request #4401:
URL: https://github.com/apache/nifi/pull/4401
… importing
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4401: NIFI-7622 Use param context name from inside nested versioned PG when…
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4401:
URL: https://github.com/apache/nifi/pull/4401#issuecomment-663737262
Verified both the existing negative behavior using the 0.7.0 RC1 (steps described in Jira) and the fix after applying the PR. Ran `contrib-check` and all tests pass. +1, merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4401: NIFI-7622 Use param context name from inside nested versioned PG when…
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4401:
URL: https://github.com/apache/nifi/pull/4401#issuecomment-663014388
I don't think we need to block versioning, but arguably we maybe don't need to store the param-context name on the shell process group that contains the pointer to the nested versioned PG, that is what is causing the issue. Using the correct param context from the actual nested versioned PG during import solves the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4401: NIFI-7622 Use param context name from inside nested versioned PG when…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4401:
URL: https://github.com/apache/nifi/pull/4401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] esecules commented on pull request #4401: NIFI-7622 Use param context name from inside nested versioned PG when…
Posted by GitBox <gi...@apache.org>.
esecules commented on pull request #4401:
URL: https://github.com/apache/nifi/pull/4401#issuecomment-659026103
This exception only gets thrown when you're pulling the flow from the registry. It would be better if it blocked versioning it to the registry in the first place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org