You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/05/15 04:21:46 UTC
[GitHub] [dubbo-go] gaoxinge opened a new pull request #1200: remove reflect in grpc server
gaoxinge opened a new pull request #1200:
URL: https://github.com/apache/dubbo-go/pull/1200
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
- remove reflect for `SetProxyImpl` in grpc server
- update protobuf
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #1200: remove reflect in grpc server
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on a change in pull request #1200:
URL: https://github.com/apache/dubbo-go/pull/1200#discussion_r641170050
##########
File path: protocol/grpc/server.go
##########
@@ -134,18 +136,12 @@ func waitGrpcExporter(providerServices map[string]*config.ServiceConfig) {
func registerService(providerServices map[string]*config.ServiceConfig, server *grpc.Server) {
for key, providerService := range providerServices {
service := config.GetProviderService(key)
-
ds, ok := service.(DubboGrpcService)
if !ok {
Review comment:
> Is 'service' may be nil ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #1200: remove reflect in grpc server
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on a change in pull request #1200:
URL: https://github.com/apache/dubbo-go/pull/1200#discussion_r642005712
##########
File path: protocol/grpc/server.go
##########
@@ -134,18 +136,12 @@ func waitGrpcExporter(providerServices map[string]*config.ServiceConfig) {
func registerService(providerServices map[string]*config.ServiceConfig, server *grpc.Server) {
for key, providerService := range providerServices {
service := config.GetProviderService(key)
-
ds, ok := service.(DubboGrpcService)
if !ok {
Review comment:
`service` check exist: https://github.com/apache/dubbo-go/blob/master/config/config_loader.go#L259-L264.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1200: remove reflect in grpc server
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1200:
URL: https://github.com/apache/dubbo-go/pull/1200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #1200: remove reflect in grpc server
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on a change in pull request #1200:
URL: https://github.com/apache/dubbo-go/pull/1200#discussion_r641169387
##########
File path: protocol/grpc/server.go
##########
@@ -134,18 +136,12 @@ func waitGrpcExporter(providerServices map[string]*config.ServiceConfig) {
func registerService(providerServices map[string]*config.ServiceConfig, server *grpc.Server) {
for key, providerService := range providerServices {
service := config.GetProviderService(key)
-
ds, ok := service.(DubboGrpcService)
if !ok {
Review comment:
Is 'ds' may be nil ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1200: remove reflect in grpc server
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1200:
URL: https://github.com/apache/dubbo-go/pull/1200#issuecomment-841598463
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1200](https://codecov.io/gh/apache/dubbo-go/pull/1200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4350cb) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/968650f658b63c11bb0409897d29c57b91cfaf50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (968650f) will **decrease** coverage by `3.48%`.
> The diff coverage is `50.31%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1200 +/- ##
==========================================
- Coverage 59.53% 56.04% -3.49%
==========================================
Files 259 269 +10
Lines 12737 12827 +90
==========================================
- Hits 7583 7189 -394
- Misses 4199 4741 +542
+ Partials 955 897 -58
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/available\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXJfaW52b2tlci5nbw==) | `66.66% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `76.47% <ø> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `66.66% <ø> (ø)` | |
| [cluster/cluster\_impl/failover\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlci5nbw==) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/forking\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyLmdv) | `100.00% <ø> (ø)` | |
| ... and [268 more](https://codecov.io/gh/apache/dubbo-go/pull/1200/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1200?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1200?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d385de5...f4350cb](https://codecov.io/gh/apache/dubbo-go/pull/1200?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org