You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/05 05:08:48 UTC
[GitHub] [spark] sarutak opened a new pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
sarutak opened a new pull request #30259:
URL: https://github.com/apache/spark/pull/30259
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR change the behavior of GitHub Actions job that caches dependencies.
SPARK-33226 upgraded sbt to 1.4.1.
As of 1.3.0, sbt uses Coursier as the dependency resolver / fetcher.
So let's change the dependency cache configuration for the GitHub Actions job.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make build faster with Coursier for the GitHub Actions job.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Should be done by GitHub Actions itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722211975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #30259:
URL: https://github.com/apache/spark/pull/30259#discussion_r517821837
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -111,13 +111,13 @@ jobs:
key: ${{ matrix.java }}-${{ matrix.hadoop }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-maven-
- - name: Cache Ivy local repository
+ - name: Cache Coursier local repository
uses: actions/cache@v2
with:
- path: ~/.ivy2/cache
- key: ${{ matrix.java }}-${{ matrix.hadoop }}-ivy-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
+ path: ~/.cache/coursier
Review comment:
> BTW, I cannot find this directory in my Mac. Is it dependent on OS?
Yeah, seems so.
On macOS, it is `~/Library/Caches/Coursier`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722166817
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35248/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722146417
**[Test build #130638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130638/testReport)** for PR 30259 at commit [`018b507`](https://github.com/apache/spark/commit/018b507ef3012a8847b9270c0b9cbda7895fb1eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30259:
URL: https://github.com/apache/spark/pull/30259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722146417
**[Test build #130638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130638/testReport)** for PR 30259 at commit [`018b507`](https://github.com/apache/spark/commit/018b507ef3012a8847b9270c0b9cbda7895fb1eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722524601
Merged to master. Thank you, @sarutak and @HyukjinKwon !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722166837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30259:
URL: https://github.com/apache/spark/pull/30259#discussion_r517807972
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -111,13 +111,13 @@ jobs:
key: ${{ matrix.java }}-${{ matrix.hadoop }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-maven-
- - name: Cache Ivy local repository
+ - name: Cache Coursier local repository
uses: actions/cache@v2
with:
- path: ~/.ivy2/cache
- key: ${{ matrix.java }}-${{ matrix.hadoop }}-ivy-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
+ path: ~/.cache/coursier
Review comment:
The directories are different in OSs (https://get-coursier.io/docs/cache)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30259:
URL: https://github.com/apache/spark/pull/30259#discussion_r517808737
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -111,13 +111,13 @@ jobs:
key: ${{ matrix.java }}-${{ matrix.hadoop }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-maven-
- - name: Cache Ivy local repository
+ - name: Cache Coursier local repository
uses: actions/cache@v2
with:
- path: ~/.ivy2/cache
- key: ${{ matrix.java }}-${{ matrix.hadoop }}-ivy-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
+ path: ~/.cache/coursier
Review comment:
Thanks! @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722158840
Nice! I have been thinking about fixing it but I couldn't have a time to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722159188
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35248/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722210727
**[Test build #130638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130638/testReport)** for PR 30259 at commit [`018b507`](https://github.com/apache/spark/commit/018b507ef3012a8847b9270c0b9cbda7895fb1eb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30259:
URL: https://github.com/apache/spark/pull/30259#discussion_r517807768
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -111,13 +111,13 @@ jobs:
key: ${{ matrix.java }}-${{ matrix.hadoop }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-maven-
- - name: Cache Ivy local repository
+ - name: Cache Coursier local repository
uses: actions/cache@v2
with:
- path: ~/.ivy2/cache
- key: ${{ matrix.java }}-${{ matrix.hadoop }}-ivy-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
+ path: ~/.cache/coursier
Review comment:
Thank you, @sarutak . BTW, I cannot find this directory in my Mac. Is it dependent on OS?
```
$ ls ~/.cache/coursier
ls: /Users/dongjoon/.cache/coursier: No such file or directory
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722166837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30259: [SPARK-33353][BUILD] Cache dependencies for Coursier with new sbt in GitHub Actions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30259:
URL: https://github.com/apache/spark/pull/30259#issuecomment-722211975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org