[GitHub] [pinot] apucher commented on a change in pull request #8207: Adding secure grpc query server support

[GitBox <gi...@apache.org>]

apucher commented on a change in pull request #8207:
URL: https://github.com/apache/pinot/pull/8207#discussion_r808538525



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/grpc/GrpcQueryClient.java
##########
@@ -50,14 +89,52 @@ public GrpcQueryClient(String host, int port, Config config) {
     private static final int DEFAULT_MAX_INBOUND_MESSAGE_BYTES_SIZE = 128 * 1024 * 1024;
     private final int _maxInboundMessageSizeBytes;
     private final boolean _usePlainText;
+    private final String _tlsKeyStorePath;
+    private final String _tlsKeyStorePassword;
+    private final String _tlsKeyStoreType;
+    private final String _tlsTrustStorePath;
+    private final String _tlsTrustStorePassword;
+    private final String _tlsTrustStoreType;

Review comment:
       imo store these properties directly in a `TlsConfig` instance. that way, you can re-use the unified TlsUtils parsing mechanism




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org