[GitHub] [tomcat] ChristopherSchultz edited a comment on issue #232: Fix handling of query parameters with no value, like `?foo`

[GitBox <gi...@apache.org>]

ChristopherSchultz edited a comment on issue #232: Fix handling of query parameters with no value, like `?foo`
URL: https://github.com/apache/tomcat/pull/232#issuecomment-576357046
 
 
   I still don't understand the ask, here. It looks like you are taking a situation where you CAN tell whether a parameter exists and turning it into a situation where you CANNOT tell that it exists. That's a net loss in functionality IMO.
   
   It also violates a part of the servlet specification IMO: `getParameter` states that it returns `null` if a parameter does not exist, and I believe that, implicitly, it is stating that the method will return non-`null` if the parameter *does* exist. This PR violates that implicit requirement and is therefore rejected.
   
   You may publish your own code if you choose to, but this PR will not be merged.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org