You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by isper3at <gi...@git.apache.org> on 2017/10/05 20:39:50 UTC
[GitHub] incubator-rya pull request #239: Rya 398
GitHub user isper3at opened a pull request:
https://github.com/apache/incubator-rya/pull/239
Rya 398
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
Changed beforeclass to before, removed System.out.println()'s
### Tests
N/A
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-398)
### Checklist
- [ ] Code Review
- [x] Squash Commits
#### People To Reivew
@jdasch
@meiercaleb
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/isper3at/incubator-rya RYA-398
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #239
----
commit 99bb5678047786a45516692395f951061361d1d8
Author: Andrew Smith <sm...@gmail.com>
Date: 2017-10-05T18:45:09Z
RYA-397 Renamed MockMongoSingleton/Factory to Embedded
Since they create/use Embedded Mongo, not Mock
renamed to show what they actually use.
commit b99781d18c02b8271765755a731397b0240c873a
Author: Andrew Smith <sm...@gmail.com>
Date: 2017-10-05T20:26:25Z
RYA-398 Changed BeforeClass to Before
If MongEntityIndexTest gets run first, it will fail
since conf hasn't been initialized yet
----
---
[GitHub] incubator-rya issue #239: Rya 398
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/239
Oh, and this built for me fine.
---
[GitHub] incubator-rya issue #239: Rya 398
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/239
RYA-397 was the rename of mockmongo stuff, RYA-398 was fixing the `MongoEntityIndexTest`
---
[GitHub] incubator-rya issue #239: Rya 398
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/239
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/516/
---
[GitHub] incubator-rya issue #239: Rya 398
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/239
Caleb, RYA-353 handles the Test to IT refactor.
---
[GitHub] incubator-rya pull request #239: Rya 398
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/239
---
[GitHub] incubator-rya pull request #239: Rya 398
Posted by meiercaleb <gi...@git.apache.org>.
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/239#discussion_r143231961
--- Diff: extras/indexing/src/test/java/org/apache/rya/indexing/mongo/MongoEntityIndexTest.java ---
@@ -54,11 +55,11 @@
.build());
private static final RyaURI RYA_PERSON_TYPE = new RyaURI("urn:person");
- private static EntityIndexOptimizer optimizer;
- private static EntityStorage entityStorage;
+ private EntityIndexOptimizer optimizer;
+ private EntityStorage entityStorage;
- @BeforeClass
- public static void beforeClass() throws Exception {
--- End diff --
Decided to change this to @Before as opposed to changing parent init to @BeforeClass?
---