You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2009/01/23 00:47:59 UTC

[jira] Updated: (HADOOP-5045) Remove deprecated FileSystem.isDirectory()

     [ https://issues.apache.org/jira/browse/HADOOP-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-5045:
------------------------------------

    Attachment: 5045.patch

FileSystem currently has two convenient methods - {{isDirectory(path)}} and {{isFile(path)}}. Both of this can cause some one to write code that creates {{FileStatus}} unnecessarily. However previously only {{isDirectory(path)}} was deprecated.

There are many instances in the code that are using both these methods. I think it is a convenient methods that prevents having multiple instances of equivalent implementation. My suggestion is to de-deprecate the method. I have attached a patch to do the same. The patch also modifies code to reuse {{FileStatus}} where it is possible.

> Remove deprecated FileSystem.isDirectory()
> ------------------------------------------
>
>                 Key: HADOOP-5045
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5045
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Suresh Srinivas
>         Attachments: 5045.patch
>
>
> We should remove FileSystem.isDirectory().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.