[jira] [Commented] (AMQ-7118) KahaDB store limit can be exceeded with durable subscribers.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706200#comment-16706200 ] 

ASF GitHub Bot commented on AMQ-7118:
-------------------------------------

GitHub user heathkesler opened a pull request:

    https://github.com/apache/activemq/pull/326

    AMQ-7118: fix issue with the unchanged acknowledgement map.

    If the kahadb ack message file map has not changed, then there is no reason to write it again.  So all the kahadb store tests and activemq unit test suite pass. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heathkesler/activemq AMQ7118-ack

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #326
    
----
commit 7dfecde307e61420b179ed54540953132371d278
Author: hkesler <hk...@...>
Date:   2018-12-02T03:34:31Z

    AMQ-7118: fix the issue with the unchanged ack continues to get written to the data files

commit 5f4fc0793cec914b8990a567f5fdc48fd2aeb9c8
Author: hkesler <hk...@...>
Date:   2018-12-02T03:36:04Z

    remove merge file

----


> KahaDB store limit can be exceeded with durable subscribers.
> ------------------------------------------------------------
>
>                 Key: AMQ-7118
>                 URL: https://issues.apache.org/jira/browse/AMQ-7118
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: KahaDB
>    Affects Versions: 5.16.0, 5.15.8
>         Environment: JDK 8
>            Reporter: Jamie goodyear
>            Priority: Critical
>             Fix For: 5.15.8
>
>         Attachments: kahaCommands.jpg
>
>
> KahaDB store limit can be exceeded with durable subscribers.
> AMQ with store limit set, we can observe that the usage continues to increase AFTER PFC is engaged. Given time, this growth stabilizes. The issue of having exceeded the store limit remains.
> See below output from KahaDB dump in attachments:
> This appears to be caused by checkpointAckMessageFileMap. The log files are not GC'd, and the KAHA_ACK_MESSAGE is replicated and the DB log files continue to expand - this can become exponential. Side effect of also not checking storage size in checkpoint update can cause the DB log files to exceed any set limits. The real critical part is the duplicated and leaking Kaha messages which appears to happen with durable subscribers.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)