You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/20 17:46:18 UTC

[GitHub] [superset] geido commented on a change in pull request #14199: chore: Removes ColorSchemeControl.less

geido commented on a change in pull request #14199:
URL: https://github.com/apache/superset/pull/14199#discussion_r616906931



##########
File path: superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
##########
@@ -74,11 +72,26 @@ export default class ColorSchemeControl extends React.PureComponent {
 
     return (
       <Tooltip id={`${currentScheme.id}-tooltip`} title={currentScheme.label}>
-        <ul className="color-scheme-container" data-test={currentScheme.id}>
+        <ul
+          css={{

Review comment:
       Hi @michael-s-molina. I recall having a small discussion about the css approach VS the currently adopted styled approach. However, I don't recall we taking a decision so I'd assume we should stick with what we have to avoid inconsistencies and bring this conversation to more people to see what they think before going too much in this direction.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org