[GitHub] [airflow] Taragolis commented on pull request #24306: Fix: `emr_conn_id` should be optional in `EmrCreateJobFlowOperator`

[GitBox <gi...@apache.org>]

Taragolis commented on PR #24306:
URL: https://github.com/apache/airflow/pull/24306#issuecomment-1150053649

   > We can't keep aws_conn_id and emr_conn_id default values None because if the user do pass aws_conn_id then we accuse that the value is aws_default across the operator/sensor.
   
   BTW, `AwsBaseHook` handle case if `aws_conn_id=None` and use default boto3 behaviour 
   https://github.com/apache/airflow/blob/01a52ccb53bc805308bd085dc51ae4674dd5eb4a/airflow/providers/amazon/aws/hooks/base_aws.py#L418-L422
   
   So it doesn't raise any error now - only static checks warning in IDE
   ```
   AIRFLOW_CTX_DAG_ID=example_emr_job_flow_manual_steps
   AIRFLOW_CTX_TASK_ID=create_job_flow
   AIRFLOW_CTX_EXECUTION_DATE=2022-06-07T10:28:15.046932+00:00
   AIRFLOW_CTX_TRY_NUMBER=8
   AIRFLOW_CTX_DAG_RUN_ID=manual__2022-06-07T10:28:15.046932+00:00
   [2022-06-08, 15:10:55 UTC] {emr.py:300} INFO - Creating JobFlow using aws-conn-id: None, emr-conn-id: emr_default
   [2022-06-08, 15:10:55 UTC] {base.py:68} INFO - Using connection ID 'emr_default' for task execution.
   [2022-06-08, 15:10:55 UTC] {credentials.py:1180} INFO - Found credentials in environment variables.
   [2022-06-08, 15:10:56 UTC] {emr.py:314} INFO - JobFlow with id j-1Y1LXW4LWC1Y1 created
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org