You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Kamil Bregula (Jira)" <ji...@apache.org> on 2020/01/03 11:40:00 UTC
[jira] [Updated] (AIRFLOW-1431) Cannot create connection for GCP
using CLI
[ https://issues.apache.org/jira/browse/AIRFLOW-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kamil Bregula updated AIRFLOW-1431:
-----------------------------------
Component/s: gcp
> Cannot create connection for GCP using CLI
> ------------------------------------------
>
> Key: AIRFLOW-1431
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1431
> Project: Apache Airflow
> Issue Type: Bug
> Components: cli, gcp
> Affects Versions: 1.8.0
> Environment: Python 3
> Reporter: peay
> Priority: Minor
>
> {{airflow connections --add}} only takes an URI argument, and deduces the connection type from the scheme, and other fields from hostname, etc.
> The connection type for the GCP connection is {{google_cloud_platform}}.
> This is not a valid scheme according to {{urllib.parse.urlparse}}:
> {code}
> >>> from urllib.parse import urlparse
> >>> urlparse("google_cloud_platform://hostname")
> ParseResult(scheme='', netloc='', path='google_cloud_platform://hostname', params='', query='', fragment='')
> >>> urlparse("platform://hostname")
> ParseResult(scheme='platform', netloc='hostname', path='', params='', query='', fragment='')
> {code}
> See https://tools.ietf.org/html/rfc3986.html#section-3.1 which specifies {{scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )}}
> As a consequence, it is not currently possible to add GCP connections using the CLI.
> Changing the connection name to {{gcp}} would solve it properly but may require lots of small modifications accross the codebase. Alternatively,
> {code}
> if scheme == "gcp":
> schema = "google_cloud_platform"
> {code}
> right after after parsing should be a simple self-contained fix. There is already a similar fix in there for {{postgres -> postgresql}}. On the downside, this introduces a special case that would need to be documented.
> A last option would be to add an argument to override the scheme from the URI. This would be backward compatible.
> I'll be happy to contribute a PR if we can agree on a plan.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)