You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/20 22:41:54 UTC
[GitHub] [solr] HoustonPutman opened a new pull request #550: SOLR-15917: Rename contrib -> modules
HoustonPutman opened a new pull request #550:
URL: https://github.com/apache/solr/pull/550
https://issues.apache.org/jira/browse/SOLR-15917
This is a big patch obviously, but I think I've curated into some reasonable commits.
I've run the following gradle commands, and all look good:
- `check`
- `installDist`
- `testDocker`
- `testDockerfileOfficial`
Happy to test whatever else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ctargett commented on pull request #550: SOLR-15917: Rename contrib -> modules
Posted by GitBox <gi...@apache.org>.
ctargett commented on pull request #550:
URL: https://github.com/apache/solr/pull/550#issuecomment-1018530029
I'm fine with merging this and dealing with the merge conflicts in the Antora branch, I suspect these would be relatively minor. If this is ready, let's keep making progress IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #550: SOLR-15917: Rename contrib -> modules
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #550:
URL: https://github.com/apache/solr/pull/550#issuecomment-1018181291
It might be worth testing nightly?
Here is an example of testing all the `hdfs` related tests that I've been running for other stuff. It should take about 20 min:
```
/gradlew test --tests "*hdfs*" --tests "*Hdfs*" --tests "*HDFS*" --tests "*Hadoop*" -Ptests.jvms=4 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.nightly=true -Ptests.awaitsfix=false -Ptests.badapples=false -Ptests.file.encoding=UTF-8
```
I have no idea how long nightly tests take regularly. Feel free to play with with `--tests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #550: SOLR-15917: Rename contrib -> modules
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #550:
URL: https://github.com/apache/solr/pull/550#issuecomment-1018754574
Ok after many rounds of testing the Nightly & HDFS tests, only 1 fails: `SharedFSAutoReplicaFailoverTest`. However this fails on main for me consistently, so I don't think it is relevant.
Will make a writeup on `major-changes-in-9.adoc`, then after a review of that I'll go ahead and merge (& backport) this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #550: SOLR-15917: Rename contrib -> modules
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #550:
URL: https://github.com/apache/solr/pull/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org