You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jp...@apache.org on 2017/11/10 23:35:46 UTC
[1/2] mesos git commit: Deleted Argv copy constructor and assignment
members.
Repository: mesos
Updated Branches:
refs/heads/master 2854f3b6a -> 2075c1ba3
Deleted Argv copy constructor and assignment members.
`os::raw::Argv` requires a user-defined copy constructor and
assignment operator but doesn't define any. Delete the default
ones to prevent a silent double-free.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2075c1ba
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2075c1ba
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2075c1ba
Branch: refs/heads/master
Commit: 2075c1ba3b030691e7d4521509f15704ea184e02
Parents: d11b66a
Author: James Peach <jp...@apache.org>
Authored: Fri Nov 10 13:40:04 2017 -0800
Committer: James Peach <jp...@apache.org>
Committed: Fri Nov 10 14:54:17 2017 -0800
----------------------------------------------------------------------
3rdparty/stout/include/stout/os/raw/argv.hpp | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/2075c1ba/3rdparty/stout/include/stout/os/raw/argv.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os/raw/argv.hpp b/3rdparty/stout/include/stout/os/raw/argv.hpp
index 5e7711b..8680c46 100644
--- a/3rdparty/stout/include/stout/os/raw/argv.hpp
+++ b/3rdparty/stout/include/stout/os/raw/argv.hpp
@@ -36,6 +36,9 @@ namespace raw {
class Argv
{
public:
+ Argv(const Argv&) = delete;
+ Argv& operator=(const Argv&) = delete;
+
template <typename Iterable>
explicit Argv(const Iterable& iterable)
{
[2/2] mesos git commit: Made Envp conversion operator consistent with
Argv.
Posted by jp...@apache.org.
Made Envp conversion operator consistent with Argv.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d11b66a2
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d11b66a2
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d11b66a2
Branch: refs/heads/master
Commit: d11b66a2870623fa5b69760afc9baf487bcc0d90
Parents: 2854f3b
Author: James Peach <jp...@apache.org>
Authored: Fri Nov 10 13:39:48 2017 -0800
Committer: James Peach <jp...@apache.org>
Committed: Fri Nov 10 14:54:17 2017 -0800
----------------------------------------------------------------------
3rdparty/stout/include/stout/os/raw/environment.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/d11b66a2/3rdparty/stout/include/stout/os/raw/environment.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/os/raw/environment.hpp b/3rdparty/stout/include/stout/os/raw/environment.hpp
index 51c93f5..2080016 100644
--- a/3rdparty/stout/include/stout/os/raw/environment.hpp
+++ b/3rdparty/stout/include/stout/os/raw/environment.hpp
@@ -182,7 +182,7 @@ public:
delete[] envp;
}
- operator char**()
+ operator char**() const
{
return envp;
}