You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/01/16 00:17:27 UTC
Review Request 42336: Documented endpoint failure when HTTP
authentication disabled.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42336/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
Bugs: MESOS-4382
https://issues.apache.org/jira/browse/MESOS-4382
Repository: mesos
Description
-------
Documented endpoint failure when HTTP authentication is disabled.
The `/reserve` and `/unreserve` endpoints currently do not work when HTTP authentication is disabled. To enable correct behavior, the `principal` field of `ReservationInfo` is being migrated from `required` to `optional`. This patch documents this behavior of these endpoints.
Diffs
-----
docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43
Diff: https://reviews.apache.org/r/42336/diff/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 42336: Documented endpoint failure when HTTP
authentication disabled.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42336/#review114880
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 16, 2016, 4:38 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42336/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 4:38 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-4382
> https://issues.apache.org/jira/browse/MESOS-4382
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented endpoint failure when HTTP authentication is disabled.
>
> The `/reserve` and `/unreserve` endpoints currently do not work when HTTP authentication is disabled. To enable correct behavior, the `principal` field of `ReservationInfo` is being migrated from `required` to `optional`. This patch documents this behavior of these endpoints.
>
>
> Diffs
> -----
>
> docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43
>
> Diff: https://reviews.apache.org/r/42336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 42336: Documented endpoint failure when HTTP
authentication disabled.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42336/
-----------------------------------------------------------
(Updated Jan. 16, 2016, 4:38 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
Changes
-------
Added target version to docs.
Bugs: MESOS-4382
https://issues.apache.org/jira/browse/MESOS-4382
Repository: mesos
Description
-------
Documented endpoint failure when HTTP authentication is disabled.
The `/reserve` and `/unreserve` endpoints currently do not work when HTTP authentication is disabled. To enable correct behavior, the `principal` field of `ReservationInfo` is being migrated from `required` to `optional`. This patch documents this behavior of these endpoints.
Diffs (updated)
-----
docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43
Diff: https://reviews.apache.org/r/42336/diff/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 42336: Documented endpoint failure when HTTP
authentication disabled.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42336/#review114861
-----------------------------------------------------------
docs/reservation.md (line 60)
<https://reviews.apache.org/r/42336/#comment175701>
s/in a future version/after the deprecation cycle of 0.27.0 ?
- Guangya Liu
On 一月 15, 2016, 11:17 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42336/
> -----------------------------------------------------------
>
> (Updated 一月 15, 2016, 11:17 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-4382
> https://issues.apache.org/jira/browse/MESOS-4382
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented endpoint failure when HTTP authentication is disabled.
>
> The `/reserve` and `/unreserve` endpoints currently do not work when HTTP authentication is disabled. To enable correct behavior, the `principal` field of `ReservationInfo` is being migrated from `required` to `optional`. This patch documents this behavior of these endpoints.
>
>
> Diffs
> -----
>
> docs/reservation.md a5dbc0abd5d9aef04064dc2a1dff7eb118147e43
>
> Diff: https://reviews.apache.org/r/42336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>