[GitHub] [spark] cloud-fan commented on a change in pull request #27937: [WIP][SPARK-30127][SQL] Support case class parameter for typed Scala UDF

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27937: [WIP][SPARK-30127][SQL] Support case class parameter for typed Scala UDF
URL: https://github.com/apache/spark/pull/27937#discussion_r394350313
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
 ##########
 @@ -59,14 +64,22 @@ case class ScalaUDF(
 
   override def toString: String = s"${udfName.getOrElse("UDF")}(${children.mkString(", ")})"
 
+  private def createToScalaConverter(i: Int, dataType: DataType): Any => Any = {
+    val encoder = inputEncoders(i)
+    encoder.isSerializedAsStructForTopLevel match {
 
 Review comment:
   it's weir to pattern match a boolean, can we write `if else`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org