[jira] [Commented] (OPENNLP-870) Please Make ContextGenerator a Generic Type

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15773551#comment-15773551 ] 

ASF GitHub Bot commented on OPENNLP-870:
----------------------------------------

GitHub user danielruss opened a pull request:

    https://github.com/apache/opennlp/pull/19

    OPENNLP-870: ContextGenerator is now Generic

    Small change to make ContextGenerator a Generic Class

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danielruss/opennlp OPENNLP-870

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit 4f8254516dfd3316bd5b3b49bb15fca489d28304
Author: Daniel Russ <dr...@mail.nih.gov>
Date:   2016-12-23T19:35:12Z

    OPENNLP-870: ContextGenerator is now Generic

----


> Please Make ContextGenerator a Generic Type
> -------------------------------------------
>
>                 Key: OPENNLP-870
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-870
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Machine Learning
>            Reporter: Daniel Russ
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> public interface ContextGenerator<T> {
>   /**
>    * Builds up the list of contextual predicates given an Object.
>    */
>   public String[] getContext(T o);
> }
> If this is a generic method, it makes writing ContextGenerators easier to debug at compile time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)