You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/10/31 12:36:52 UTC

[GitHub] walking98 commented on a change in pull request #510: [ISSUE478]Polish async send message sample

walking98 commented on a change in pull request #510: [ISSUE478]Polish async send message sample
URL: https://github.com/apache/rocketmq/pull/510#discussion_r229674858
 
 

 ##########
 File path: example/src/main/java/org/apache/rocketmq/example/simple/AsyncProducer.java
 ##########
 @@ -55,6 +61,7 @@ public void onException(Throwable e) {
                 e.printStackTrace();
             }
         }
+        countDownLatch.await(5, TimeUnit.SECONDS);
 
 Review comment:
   LGTM.
   btw, I am wondering if we can improve internally in product for the AsyncProducer.java, that will make users easier to use. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services