You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/18 01:11:32 UTC
[GitHub] GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters]
Expanding the Adhoc Filter popover when the content expands
GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
URL: https://github.com/apache/incubator-superset/pull/5032
Previously to this PR, when adding/viewing a simple filter with number of comparators this could happen:
That doesn't look so great and also makes it quite annoying to make any changes because you are forced to manually expand the box to hit save. In this PR I have the popover expand in reaction when the input field expands.
test plan:
- ran the example shown in the above gif
- ran the spec
reviewers:
@michellethomas @john-bodley @williaster @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org