[jira] [Work logged] (GOBBLIN-687) Pass TopologySpec map to DagManager to allow reuse of SpecExecutors during DAG deserialization

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-687?focusedWorklogId=201080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201080 ]

ASF GitHub Bot logged work on GOBBLIN-687:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Feb/19 04:48
            Start Date: 20/Feb/19 04:48
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2559: GOBBLIN-687: Pass TopologySpec map to DagManager to allow reuse of Sp…
URL: https://github.com/apache/incubator-gobblin/pull/2559
 
 
   …ecExecutors during DAG deserialization.
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-687
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   DagManager maintains state of all currently executing DAGs, by serializing each DAG on compilation and persisting it to a durable store. The serialized DAG includes Job config as well as the SpecExecutor config for each job in the DAG. This is done to correctly resume execution of DAGs in case of service restarts or leadership change. 
   
   Currently, on service restart/leadership change, the new master de-serializes SpecExecutor config and creates a SpecExecutor instance for each job in the DAG. If the number of DAGs is large, this can result in many connections to the underlying executor instance. The proposed fix allows the DagManager to re-use the SpecExecutor instances created by the TopologySpecFactory when it deserializes a DAG.
   
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Enhanced unit tests in FSDagStateStoreTest and tested in local environment.
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 201080)
            Time Spent: 10m
    Remaining Estimate: 0h

> Pass TopologySpec map to DagManager to allow reuse of SpecExecutors during DAG deserialization
> ----------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-687
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-687
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-service
>    Affects Versions: 0.15.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Abhishek Tiwari
>            Priority: Major
>             Fix For: 0.15.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> DagManager maintains state of all currently executing DAGs, by serializing each DAG on compilation and persisting it to a durable store. The serialized DAG includes Job config as well as the SpecExecutor config for each job in the DAG. This is done to correctly resume execution of DAGs in case of service restarts or leadership change. 
> Currently, on service restart/leadership change, the new master de-serializes SpecExecutor config and creates a SpecExecutor instance for each job in the DAG. If the number of DAGs is large, this can result in many connections to the underlying executor instance. The proposed fix allows the DagManager to re-use the SpecExecutor instances created by the TopologySpecFactory when it deserializes a DAG.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)