You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/06/15 14:15:50 UTC
Review Request 60120: Remove metainfo latest url
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60120/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-21260
https://issues.apache.org/jira/browse/AMBARI-21260
Repository: ambari
Description
-------
Remove storing the latest base url from the {{metainfo}} table. VDF negates the need for this old data.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8d262e269b
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 84fe7fb420
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java a6177291a6
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5a6673b807
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java a1587b92e1
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 51d386b9fc
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 349cb54a66
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 59a74d3b04
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java d39dd480da
Diff: https://reviews.apache.org/r/60120/diff/1/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 60120: Remove metainfo latest url
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On June 15, 2017, 6:11 p.m., Nate Cole wrote:
> > There's more code than what you have changed:
> >
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java#L144-L152
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java#L888-L899
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java#L84-L107
> >
> > If you take out those methods and start fixing compile errors then you should get the rest :)
fixed
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60120/#review178006
-----------------------------------------------------------
On June 16, 2017, 4:07 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60120/
> -----------------------------------------------------------
>
> (Updated June 16, 2017, 4:07 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21260
> https://issues.apache.org/jira/browse/AMBARI-21260
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove storing the latest base url from the {{metainfo}} table. VDF negates the need for this old data.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 89656837ce
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 807bded873
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8d262e269b
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 84fe7fb420
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java a6177291a6
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java e9dbe0b1fc
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 96dfc13735
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java c4fab99dbe
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5a6673b807
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java a1587b92e1
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 51d386b9fc
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java c153381dc0
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 349cb54a66
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3215e7246d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 59a74d3b04
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java d39dd480da
>
>
> Diff: https://reviews.apache.org/r/60120/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 60120: Remove metainfo latest url
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60120/#review178006
-----------------------------------------------------------
There's more code than what you have changed:
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java#L144-L152
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java#L888-L899
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java#L84-L107
If you take out those methods and start fixing compile errors then you should get the rest :)
- Nate Cole
On June 15, 2017, 10:15 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60120/
> -----------------------------------------------------------
>
> (Updated June 15, 2017, 10:15 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21260
> https://issues.apache.org/jira/browse/AMBARI-21260
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove storing the latest base url from the {{metainfo}} table. VDF negates the need for this old data.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8d262e269b
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 84fe7fb420
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java a6177291a6
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5a6673b807
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java a1587b92e1
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 51d386b9fc
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 349cb54a66
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 59a74d3b04
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java d39dd480da
>
>
> Diff: https://reviews.apache.org/r/60120/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 60120: Remove metainfo latest url
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60120/#review178104
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On June 16, 2017, 9:07 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60120/
> -----------------------------------------------------------
>
> (Updated June 16, 2017, 9:07 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21260
> https://issues.apache.org/jira/browse/AMBARI-21260
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove storing the latest base url from the {{metainfo}} table. VDF negates the need for this old data.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 89656837ce
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 807bded873
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8d262e269b
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 84fe7fb420
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java a6177291a6
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java e9dbe0b1fc
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 96dfc13735
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java c4fab99dbe
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5a6673b807
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java a1587b92e1
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 51d386b9fc
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java c153381dc0
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 349cb54a66
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3215e7246d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 59a74d3b04
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java d39dd480da
>
>
> Diff: https://reviews.apache.org/r/60120/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 60120: Remove metainfo latest url
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60120/#review178103
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 16, 2017, 9:07 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60120/
> -----------------------------------------------------------
>
> (Updated June 16, 2017, 9:07 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21260
> https://issues.apache.org/jira/browse/AMBARI-21260
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove storing the latest base url from the {{metainfo}} table. VDF negates the need for this old data.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 89656837ce
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 807bded873
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8d262e269b
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 84fe7fb420
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java a6177291a6
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java e9dbe0b1fc
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 96dfc13735
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java c4fab99dbe
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5a6673b807
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java a1587b92e1
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 51d386b9fc
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java c153381dc0
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 349cb54a66
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3215e7246d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 59a74d3b04
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java d39dd480da
>
>
> Diff: https://reviews.apache.org/r/60120/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 60120: Remove metainfo latest url
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60120/
-----------------------------------------------------------
(Updated June 16, 2017, 4:07 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Removed code pointed out by Nate
Bugs: AMBARI-21260
https://issues.apache.org/jira/browse/AMBARI-21260
Repository: ambari
Description
-------
Remove storing the latest base url from the {{metainfo}} table. VDF negates the need for this old data.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 89656837ce
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 807bded873
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8d262e269b
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 84fe7fb420
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java a6177291a6
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java e9dbe0b1fc
ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 96dfc13735
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java c4fab99dbe
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5a6673b807
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java a1587b92e1
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 51d386b9fc
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java c153381dc0
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 349cb54a66
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3215e7246d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 59a74d3b04
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java d39dd480da
Diff: https://reviews.apache.org/r/60120/diff/2/
Changes: https://reviews.apache.org/r/60120/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko