You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/17 20:12:20 UTC

[GitHub] ddavydenko commented on a change in pull request #13921: Version switching user experience improvements

ddavydenko commented on a change in pull request #13921: Version switching user experience improvements
URL: https://github.com/apache/incubator-mxnet/pull/13921#discussion_r248823592
 
 

 ##########
 File path: docs/_static/js/docversion.js
 ##########
 @@ -18,16 +18,23 @@
  */
 
 /* Set the version of the website */
-function setVersion(){
-        let doc = window.location.pathname.match(/^\/(api\/.*)$/) || window.location.pathname.match(/^\/versions\/[^*]+\/(api\/.*)$/);
+function setVersion(anchor){
+        if (arguments.length==0) {
+            anchor = window.location.hash
+        };
+        console.log('anchor: ', anchor, arguments.length, window.location.hash, window.location.search);
 
 Review comment:
   I suggest to remove this debugging statement from production code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services