[GitHub] [superset] villebro commented on a diff in pull request #20107: fix(generic-chart-axes): set x-axis if unset and ff is enabled

[GitBox <gi...@apache.org>]

villebro commented on code in PR #20107:
URL: https://github.com/apache/superset/pull/20107#discussion_r875698359


##########
superset-frontend/src/explore/store.js:
##########
@@ -64,8 +64,14 @@ export function getControlsState(state, inputFormData) {
 export function applyDefaultFormData(inputFormData) {
   const datasourceType = inputFormData.datasource.split('__')[1];
   const vizType = inputFormData.viz_type;
-  const controlsState = getAllControlsState(vizType, datasourceType, null, {

Review Comment:
   This would have caused a type error if the file were TypeScript: the signature of `getAllControlsState` requires the third parameter to be `ControlPanelState` (here `null`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org