[jira] [Commented] (PIG-2923) Lazily register bags with SpillableMemoryManager

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459751#comment-13459751 ] 

Alan Gates commented on PIG-2923:
---------------------------------

In DefaultAbstractBag it would be good to have a comment on the definition of SPILL_REGISTER_THRESHOLD to say what the unit is (K I think).

DefaultAbstractBag.markSpillableIfNecessary in the line:
{code}
if (!spillableRegistered && size() == SPILL_REGISTER_THRESHOLD)
{code}

Shouldn't that be >= instead of == ?  You may have already passed the size the first time you check.

In TestDataBag, why control the seed?  Is this for repeatability of the test?
                
> Lazily register bags with SpillableMemoryManager
> ------------------------------------------------
>
>                 Key: PIG-2923
>                 URL: https://issues.apache.org/jira/browse/PIG-2923
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>         Attachments: bagspill_delayed_register.patch
>
>
> Currently, all Spillable DataBags get registered by the BagFactory at the moment of creation. In practice, a lot of these bags will not get large enough to be worth spilling; we can avoid a lot of memory overhead and cheapen the process of finding a bag to spill when we do need it, by allowing Bags themselves to register when they grow to some respectable threshold.
> Related JIRAs: PIG-2917, PIG-2918

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira