You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2023/05/24 09:58:55 UTC
[GitHub] [incubator-pekko] raboof opened a new pull request, #336: Document JDK build prerequisites
raboof opened a new pull request, #336:
URL: https://github.com/apache/incubator-pekko/pull/336
I think mentioning the need to install Java 8 should be sufficient here: in the vast majority of cases it should be picked up automatically, and otherwise the build error tells you how to explicitly point to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #336: Document JDK build prerequisites
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #336:
URL: https://github.com/apache/incubator-pekko/pull/336#discussion_r1203830247
##########
README.md:
##########
@@ -19,7 +19,8 @@ Building from Source
--------------------
- You will need to install [sbt](https://www.scala-sbt.org/) if you don't already have it installed
-- You should have a Java Runtime installed. Java 8 minimum.
+- The Java Development Kit (JDK) used for running sbt should be Java 11 at minimum.
Review Comment:
Thanks - this is a good start. One nit - could you put sbt bit after the Java bit? In hindsight, sbt needs Java so we list Java first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #336: Document JDK build prerequisites
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #336:
URL: https://github.com/apache/incubator-pekko/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org