You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/12 15:32:27 UTC
[GitHub] [apisix] wu-sheng opened a new issue #4232: Plugin interaction and SkyWalking native log format with trace context
wu-sheng opened a new issue #4232:
URL: https://github.com/apache/apisix/issues/4232
@dmsolr @moonming I want to discuss an enhancement feature for APISIX ecosystem about observability.
SkyWalking built its native tracer implementation for Nginx and APISIX, so we have this, http://apisix.apache.org/docs/apisix/plugins/skywalking/. Which supports tracing and backed by OAP's analysis capability, we have topology with metrics about traffic.
Now, with the latest [SkyWalking's log analyzer](https://skywalking.apache.org/docs/main/v8.5.0/en/setup/backend/log-analyzer/), we should consider looping logs in. So 2 questions should be answered
1. Could 2 plugins interact with each other? If so, how.
2. Does APISIX want to adopt SkyWalking native log format? https://github.com/apache/skywalking-data-collect-protocol/blob/master/logging/Logging.proto Although APISIX is only good at HTTP+JSON, so we could leverage satellite to forward, but it is better to add a native gRPC reporter into satellite
If you feel interests, let's work on this together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-840270093
> I think it is good to adopt SkyWalking native log format when skywalking tracer plugin was enabled.
I think we could include it in skywalking-nginx-lua repo if that makes senses to APISIX community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dmsolr commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-1049674520
APISIX has supported reporting access-log with trace context and error-log to SkyWalking by #5478 and #4633.
So, I think this issue could be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-840269592
> plugins interact means passing trace context in the scope of a request. We can use ngx.ctx to propagate it.
Yes, it could be, but we should take care of the priority and execution sequence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-1050446049
Thanks, look forward to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-839871125
I know we talked about ALS, which could be another separate feature. As general logs are more flexible, ALS is focusing on topology and traffic metrics analysising.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dmsolr commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-1050436293
We can get `tracing_context` in other plugins by `ngx.ctx.tracing_context`. So I think (1) is supported as well.
I will submit a PR to add some explanations to the related document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dmsolr commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-840258528
1. `plugins interact` means passing trace context in the scope of a request. We can use `ngx.ctx` to propagate it.
2. I think it is good to adopt SkyWalking native log format when `skywalking tracer plugin` was enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4232: Plugin interaction and SkyWalking native log format with trace context
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4232:
URL: https://github.com/apache/apisix/issues/4232#issuecomment-1049738500
I think (1) is not supported? Do we skip it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org