You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:35:29 UTC

[GitHub] [pulsar] gaoran10 opened a new pull request #11897: [Branch-2.7][Broker] Fix using partitioned topic name to get topic policies

gaoran10 opened a new pull request #11897:
URL: https://github.com/apache/pulsar/pull/11897


   ### Motivation
   
   There is a bug that using the partitioned topic name to get topic policies. The PR https://github.com/apache/pulsar/pull/11294 fix this issue, but it's hard to cherry-pick the PR to `branch-2.7`, so create this PR to fix the issue in `branch-2.7`.
   
   ### Modifications
   
   1. Fix using the partitioned topic name to get topic policies.
   2. Change some warning logs to debug level for the getting topic policies operation.
   
   ### Verifying this change
   
   The test method `TopicPoliciesTest#testBacklogQuotaWithPartitionedTopic` is used to verify getting topic policies by the partitioned topic name.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] doc-required 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] no-need-doc 
     
     (Please explain why)
     
   - [ ] doc 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #11897: [Branch-2.7][Broker] Fix using partitioned topic name to get topic policies

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11897:
URL: https://github.com/apache/pulsar/pull/11897


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 commented on a change in pull request #11897: [Branch-2.7][Broker] Fix using partitioned topic name to get topic policies

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11897:
URL: https://github.com/apache/pulsar/pull/11897#discussion_r702538020



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java
##########
@@ -593,8 +593,6 @@ public void testTlsEnabledWithoutNonTlsServicePorts() throws Exception {
 
         } catch (Exception e) {
             fail("should not fail");
-        } finally {

Review comment:
       If close the `pulsarClient`, it will cause other test methods can't use the `pulsarClient` and there is a clean operation after the test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on a change in pull request #11897: [Branch-2.7][Broker] Fix using partitioned topic name to get topic policies

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on a change in pull request #11897:
URL: https://github.com/apache/pulsar/pull/11897#discussion_r702534253



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java
##########
@@ -593,8 +593,6 @@ public void testTlsEnabledWithoutNonTlsServicePorts() throws Exception {
 
         } catch (Exception e) {
             fail("should not fail");
-        } finally {

Review comment:
       why delete this code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org