You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Zhao Yongming (JIRA)" <ji...@apache.org> on 2013/11/04 13:06:23 UTC

[jira] [Updated] (TS-2082) Remove NON_MODULAR #ifdef and others

     [ https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhao Yongming updated TS-2082:
------------------------------

    Description: 
{code}
#if TS_HAS_STANDALONE_IOCORE
# define STANDALONE_IOCORE              1
#else
# define FIXME_NONMODULAR               1
# define SPLIT_DNS                      1
# define NON_MODULAR                    1
# define HTTP_CACHE                     1
#endif
{code}
all those ifdefine states relate to some work to make iocore portable to other project, that we don't have any interest right now.

I think all those define should be cleanup to make codes alive, and we do not need to make a stand alone library right now. when we need to make the iocore into a library, we don't use #ifdefine.

let us nuke them
         Labels: cleanup  (was: )
        Summary: Remove NON_MODULAR #ifdef and others  (was: Remove NON_MODULAR #ifdef)

> Remove NON_MODULAR #ifdef and others
> ------------------------------------
>
>                 Key: TS-2082
>                 URL: https://issues.apache.org/jira/browse/TS-2082
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Leif Hedstrom
>              Labels: cleanup
>             Fix For: 5.0.0
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE              1
> #else
> # define FIXME_NONMODULAR               1
> # define SPLIT_DNS                      1
> # define NON_MODULAR                    1
> # define HTTP_CACHE                     1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not need to make a stand alone library right now. when we need to make the iocore into a library, we don't use #ifdefine.
> let us nuke them



--
This message was sent by Atlassian JIRA
(v6.1#6144)