You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/23 18:50:43 UTC

[GitHub] [beam] amaliujia commented on a change in pull request #14197: [BEAM-11945] Add debug capture to SDK harness

amaliujia commented on a change in pull request #14197:
URL: https://github.com/apache/beam/pull/14197#discussion_r599846026



##########
File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EmbeddedEnvironmentFactory.java
##########
@@ -102,6 +102,7 @@ public RemoteEnvironment createEnvironment(Environment environment, String worke
                     options,
                     loggingServer.getApiServiceDescriptor(),
                     controlServer.getApiServiceDescriptor(),
+                    null,

Review comment:
       Setting `null` seems a bit scary. Is there a better way to specify this value? Like a default/empty value instead of setting a `null`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org