[GitHub] [incubator-superset] mistercrunch commented on issue #7372: 7366: Added requirements-fill.txt file having mandatory & optional pa…

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #7372: 7366: Added requirements-fill.txt file having mandatory & optional pa…
URL: https://github.com/apache/incubator-superset/pull/7372#issuecomment-486524645
 
 
   Is this for docker? Wouldn't people no want all the junk in their image, and add a layer on top with just what they need/want? Your extra layer would add something like `RUN pip install superset[hive]` (leveraging the `extras_require` ideally)
   
   I was also wondering how this file was generated, it appears to be `pip-compile` but the command at the top got removed(?). Anyhow it should be reproducible so that every time `setup.py` changes, there's a clear process to follow to pip-compile and pin things.
   
   There's a hack to get the `extras_require` in there. https://github.com/jazzband/pip-tools/issues/331
   
   We could have a collection of `requirements.in` files that contain just `-e .` and another that's like `requirements-hive.in` that has `-e .[hive]`, and so on, for each entry in `extras_requires`. Put all of these in a `requirements/` folder as it starts to get messy in the root. Also a small shell script to re-generate all these files... Might be overkill though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org