You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by Alexis Midon <mi...@intalio.com> on 2009/02/17 21:18:21 UTC
CRLF wipe out
Hi guys,
would you have any objections if I replace all CRLF by LF in 1.X and trunk?
Respectively 114 files and 42 files would be affected.
waiting for your feedback.
Alexis
Re: CRLF wipe out
Posted by Alexis Midon <mi...@intalio.com>.
I guess so. I didn't know this command.
thanks Paul.
Alexis
On Tue, Feb 17, 2009 at 12:43 PM, Paul Brown <pa...@gmail.com> wrote:
>
>
>
>> for code review, here is the script I used: [...]
>>
>
> Couldn't you just do:
>
> find . -type file | xargs dos2unix
>
> ?
>
> -- Paul
>
Re: CRLF wipe out
Posted by Paul Brown <pa...@gmail.com>.
>
> for code review, here is the script I used: [...]
Couldn't you just do:
find . -type file | xargs dos2unix
?
-- Paul
Re: CRLF wipe out
Posted by Alexis Midon <mi...@intalio.com>.
for code review, here is the script I used:
FILENAME=$1
if file $1 | grep -i ascii > /dev/null 2>&1
then
mv $FILENAME $FILENAME.tmp
tr -d '\015' < $FILENAME.tmp >$FILENAME
rm $FILENAME.tmp
fi
Alexis
On Tue, Feb 17, 2009 at 12:18 PM, Alexis Midon <mi...@intalio.com> wrote:
>
> Hi guys,
>
> would you have any objections if I replace all CRLF by LF in 1.X and trunk?
> Respectively 114 files and 42 files would be affected.
>
> waiting for your feedback.
>
> Alexis
>
Re: CRLF wipe out
Posted by Alex Boisvert <bo...@intalio.com>.
+1 for both CR/LF and tab -> 4 spaces clean up in .java files.
On Tue, Feb 17, 2009 at 1:22 PM, Alexis Midon <mi...@intalio.com> wrote:
> yep, the "git on windows" mess to be precise.
>
> ok, for the tab, you want 4 spaces I guess?
>
>
>
> Alexis
>
>
> On Tue, Feb 17, 2009 at 1:02 PM, Tammo van Lessen <tvanlessen@gmail.com
> >wrote:
>
> > Alexis Midon wrote:
> > > Hi guys,
> > >
> > > would you have any objections if I replace all CRLF by LF in 1.X and
> > trunk?
> > > Respectively 114 files and 42 files would be affected.
> >
> > no objections at all from my side. I guess the aim is to reduce the git
> > mess?
> >
> > I recently noticed that we also have some spaces/tabs chaos in our code
> > base. Would this be the right moment to address this too?
> >
> > Cheers,
> > Tammo
> >
> > --
> > Tammo van Lessen - http://www.taval.de
> >
>
Re: CRLF wipe out
Posted by Alexis Midon <mi...@intalio.com>.
done
https://issues.apache.org/jira/browse/ODE-520
Alexis
On Tue, Feb 17, 2009 at 1:39 PM, Alexis Midon <mi...@intalio.com> wrote:
> ok, I'll go for it.
>
> Alexis
>
>
>
> On Tue, Feb 17, 2009 at 1:28 PM, Tammo van Lessen <tv...@gmail.com>wrote:
>
>> Alexis Midon wrote:
>> > yep, the "git on windows" mess to be precise.
>> >
>> > ok, for the tab, you want 4 spaces I guess?
>>
>> yep. That's at least compliant to the Java style guide. 'expand -t 4'
>> should the job I guess. I never know whether spaces or tabs are better,
>> so I leave it up to you ;) Any is better than a mix of both.
>>
>> Thanks,
>> Tammo
>>
>> --
>> Tammo van Lessen - http://www.taval.de
>>
>
>
Re: CRLF wipe out
Posted by Alexis Midon <mi...@intalio.com>.
ok, I'll go for it.
Alexis
On Tue, Feb 17, 2009 at 1:28 PM, Tammo van Lessen <tv...@gmail.com>wrote:
> Alexis Midon wrote:
> > yep, the "git on windows" mess to be precise.
> >
> > ok, for the tab, you want 4 spaces I guess?
>
> yep. That's at least compliant to the Java style guide. 'expand -t 4'
> should the job I guess. I never know whether spaces or tabs are better,
> so I leave it up to you ;) Any is better than a mix of both.
>
> Thanks,
> Tammo
>
> --
> Tammo van Lessen - http://www.taval.de
>
Re: CRLF wipe out
Posted by Tammo van Lessen <tv...@gmail.com>.
Alexis Midon wrote:
> yep, the "git on windows" mess to be precise.
>
> ok, for the tab, you want 4 spaces I guess?
yep. That's at least compliant to the Java style guide. 'expand -t 4'
should the job I guess. I never know whether spaces or tabs are better,
so I leave it up to you ;) Any is better than a mix of both.
Thanks,
Tammo
--
Tammo van Lessen - http://www.taval.de
Re: CRLF wipe out
Posted by Alexis Midon <mi...@intalio.com>.
yep, the "git on windows" mess to be precise.
ok, for the tab, you want 4 spaces I guess?
Alexis
On Tue, Feb 17, 2009 at 1:02 PM, Tammo van Lessen <tv...@gmail.com>wrote:
> Alexis Midon wrote:
> > Hi guys,
> >
> > would you have any objections if I replace all CRLF by LF in 1.X and
> trunk?
> > Respectively 114 files and 42 files would be affected.
>
> no objections at all from my side. I guess the aim is to reduce the git
> mess?
>
> I recently noticed that we also have some spaces/tabs chaos in our code
> base. Would this be the right moment to address this too?
>
> Cheers,
> Tammo
>
> --
> Tammo van Lessen - http://www.taval.de
>
Re: CRLF wipe out
Posted by Tammo van Lessen <tv...@gmail.com>.
Alexis Midon wrote:
> Hi guys,
>
> would you have any objections if I replace all CRLF by LF in 1.X and trunk?
> Respectively 114 files and 42 files would be affected.
no objections at all from my side. I guess the aim is to reduce the git
mess?
I recently noticed that we also have some spaces/tabs chaos in our code
base. Would this be the right moment to address this too?
Cheers,
Tammo
--
Tammo van Lessen - http://www.taval.de