You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Roman Shaposhnik (JIRA)" <ji...@apache.org> on 2011/02/10 00:06:57 UTC

[jira] Created: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

configure files that are generated as part of the released tarball need to have executable bit set
--------------------------------------------------------------------------------------------------

                 Key: MAPREDUCE-2314
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
            Reporter: Roman Shaposhnik
            Assignee: Roman Shaposhnik


Currently the configure files that are packaged in a tarball are -rw-rw-r--


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994993#comment-12994993 ] 

Roman Shaposhnik commented on MAPREDUCE-2314:
---------------------------------------------

To answer a chmod question -- I followed the already established pattern of not doing chmods in parallel.

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated MAPREDUCE-2314:
------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I have committed this to trunk and branch-0.22. Thanks Roman!

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995010#comment-12995010 ] 

Hudson commented on MAPREDUCE-2314:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #611 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/611/])
    MAPREDUCE-2314. configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik.


> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008260#comment-13008260 ] 

Hudson commented on MAPREDUCE-2314:
-----------------------------------

Integrated in Hadoop-Mapreduce-22-branch #38 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/38/])
    

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016930#comment-13016930 ] 

Hudson commented on MAPREDUCE-2314:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #643 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/])
    

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated MAPREDUCE-2314:
------------------------------------------

    Fix Version/s: 0.22.0

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik updated MAPREDUCE-2314:
----------------------------------------

          Component/s: build
    Affects Version/s: 0.22.0

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993285#comment-12993285 ] 

Konstantin Boudnik commented on MAPREDUCE-2314:
-----------------------------------------------

+1 patch looks good.
The only question (which you might not to know the answer for) is why chmod is force to be non-parallel. 

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik updated MAPREDUCE-2314:
----------------------------------------

    Attachment: MAPREDUCE-2314.patch

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated MAPREDUCE-2314:
------------------------------------------

    Hadoop Flags: [Reviewed]

+1 patch looks good.

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994991#comment-12994991 ] 

Roman Shaposhnik commented on MAPREDUCE-2314:
---------------------------------------------

$ ant veryclean test-patch -Dpatch.file=/home/rvs/MAPREDUCE-2314.patch -Dscratch.dir=/tmp/mapred/scratch -Dfindbugs.home=/home/rvs/findbugs-1.3.9 -Dforrest.home=/home/rvs/src/apache-forrest-0.8
.....

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.


And given that it is a build change " -1 tests included" can be ignored

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2314) configure files that are generated as part of the released tarball need to have executable bit set

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik updated MAPREDUCE-2314:
----------------------------------------

    Status: Patch Available  (was: Open)

> configure files that are generated as part of the released tarball need to have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira