You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/26 22:18:02 UTC

[GitHub] [zookeeper] jhuan31 commented on issue #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh…

jhuan31 commented on issue #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh…
URL: https://github.com/apache/zookeeper/pull/1115#issuecomment-591673349
 
 
   > Can you please introduce a `CachedThreadPool` so that a new thread does not need to be spawned for every socket?
   > 
   > https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Executors.html#newCachedThreadPool()
   
   This is for closing the quorum socket once in a while, not the client sockets. I check the link you provide and it says the thread will be terminated if not being used for 60 seconds--I would expect the life time of a learner much longer than that. So I don't see any benefit of using a thread pool, or do I miss anything? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services