You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mvolf (via GitHub)" <gi...@apache.org> on 2023/12/08 07:56:20 UTC

Re: [PR] #973 - Don't copy project if existing project-id is used [camel-karavan]

mvolf commented on PR #992:
URL: https://github.com/apache/camel-karavan/pull/992#issuecomment-1846722489

   @mgubaidullin I've updated this PR with the "quick" approach/solution for project id validation on project create/update. Now error message will be shown in the modal window if existing project-id is used.
   I plan on implementing a more elegant solution with a small, generic validation framework which could be reused and initially applying it to the create/copy project as a reference, but this should be fine as an initial solution.  
   You'll also notice that I've changed the nameFromTitle method in the CamelUI. I've added trimming to avoid having only '-' as a project id when user enters only space for project name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org