[jira] [Commented] (ZOOKEEPER-1354) AuthTest.testBadAuthThenSendOtherCommands fails intermittently

["Camille Fournier (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220628#comment-13220628 ] 

Camille Fournier commented on ZOOKEEPER-1354:
---------------------------------------------

This looks good, I'll check it in to trunk.
                
> AuthTest.testBadAuthThenSendOtherCommands fails intermittently
> --------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1354
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1354
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: ZOOKEEPER-1354.patch
>
>
> I'm seeing the following intermittent failure:
> {noformat}
> junit.framework.AssertionFailedError: Should have called my watcher expected:<1> but was:<0>
> 	at org.apache.zookeeper.test.AuthTest.testBadAuthThenSendOtherCommands(AuthTest.java:89)
> 	at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {noformat}
> The following commit introduced this test:
> bq. ZOOKEEPER-1152. Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer. (camille via breed)
> +            Assert.assertEquals("Should have called my watcher",
> +                    1, authFailed.get());
> I think it's due to either a) the code is not waiting for the
> notification to be propagated, or 2) the message doesn't make it back
> from the server to the client prior to the socket or the clientcnxn
> being closed.
> What do you think, should I just wait for the notification to arrive? or do you think it's 2). ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira