You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/12 13:45:36 UTC
[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #502: [YUNIKORN-1469] PreemptionPolicy support
pbacsko opened a new pull request, #502:
URL: https://github.com/apache/yunikorn-k8shim/pull/502
### What is this PR for?
Retrieve preemptionPolicy settings from the pod and extend the `si.AllocationAsk` message before it's sent to the core.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [x] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1469
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #502: [YUNIKORN-1469] PreemptionPolicy support
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #502:
URL: https://github.com/apache/yunikorn-k8shim/pull/502#issuecomment-1346559512
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/502?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#502](https://codecov.io/gh/apache/yunikorn-k8shim/pull/502?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (99c5e11) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/320adb92f7bf0f1f15ee2256cdeab48c042db466?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (320adb9) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 67.60% 67.68% +0.08%
==========================================
Files 42 42
Lines 7463 7488 +25
==========================================
+ Hits 5045 5068 +23
- Misses 2230 2232 +2
Partials 188 188
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/502?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `97.87% <100.00%> (+0.32%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/502/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #502: [YUNIKORN-1469] PreemptionPolicy support
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #502: [YUNIKORN-1469] PreemptionPolicy support
URL: https://github.com/apache/yunikorn-k8shim/pull/502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #502: [YUNIKORN-1469] PreemptionPolicy support
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #502:
URL: https://github.com/apache/yunikorn-k8shim/pull/502#issuecomment-1346760195
Closing in favor of #501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org