You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 05:51:47 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
viirya opened a new pull request, #1871:
URL: https://github.com/apache/arrow-rs/pull/1871
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1870.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r899264113
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+/// Represents a decimal value with precision and scale.
+/// The decimal value is represented by a signed 128-bit integer.
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.eq(&other.value)
+ }
+}
+
+impl Eq for Decimal128 {}
+
+impl Decimal128 {
+ pub fn new_from_bytes(precision: usize, scale: usize, bytes: &[u8]) -> Self {
+ let as_array = bytes.try_into();
+ let value = match as_array {
+ Ok(v) if bytes.len() == 16 => i128::from_le_bytes(v),
+ _ => panic!("Input to Decimal128 is not 128bit integer."),
Review Comment:
Good idea. I will change it to `Result`. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r898158069
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.eq(&other.value)
+ }
+}
+
+impl Eq for Decimal128 {}
+
+impl Decimal128 {
+ pub fn new_from_bytes(precision: usize, scale: usize, bytes: &[u8]) -> Self {
+ let as_array = bytes.try_into();
+ let value = match as_array {
+ Ok(v) if bytes.len() == 16 => i128::from_le_bytes(v),
+ _ => panic!("Input to Decimal128 is not 128bit integer."),
+ };
+
+ Decimal128 {
+ precision,
+ scale,
+ value,
+ }
+ }
+
+ pub fn new_from_i128(precision: usize, scale: usize, value: i128) -> Self {
Review Comment:
I think we have some time before next release to have Decimal256 and generalise the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r898157216
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.eq(&other.value)
+ }
+}
+
+impl Eq for Decimal128 {}
+
+impl Decimal128 {
+ pub fn new_from_bytes(precision: usize, scale: usize, bytes: &[u8]) -> Self {
+ let as_array = bytes.try_into();
+ let value = match as_array {
+ Ok(v) if bytes.len() == 16 => i128::from_le_bytes(v),
+ _ => panic!("Input to Decimal128 is not 128bit integer."),
+ };
+
+ Decimal128 {
+ precision,
+ scale,
+ value,
+ }
+ }
+
+ pub fn new_from_i128(precision: usize, scale: usize, value: i128) -> Self {
Review Comment:
I have considered making them generic versions. Because I only implement Decimal128 now, `new_from_i128` is used to make Decimal128 fit into existing codes.
Next step I will implement Decimal256 and try generalise it with Decimal128. I think if it works, `new_from_bytes` (maybe rename to `new_from_raw`) will be the generalised API. `new_from_i128` will be removed if the above idea works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r896426518
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
Review Comment:
I'm a bit not sure about comparing Decimal128. Although C++ Decimal128 just compares two uint64 values. We also compare i128 directly currently.
But I'm still wondering it is correct to compare two values with different scale? E.g., 100_i128 (scale 2) and 100_i128 (scale 3)? Isn't it "1.00" and "0.100" respectively?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r896400715
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Clone, Debug)]
+pub struct Decimal128 {
Review Comment:
C++ Decimal128 has implemented some operators. I don't implement the same in this change. This change tries to be functionally equal with current i128 API. We can consider to have these operators if they are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] martin-g commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
martin-g commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r898800825
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+/// Represents a decimal value with precision and scale.
+/// The decimal value is represented by a signed 128-bit integer.
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.eq(&other.value)
+ }
+}
+
+impl Eq for Decimal128 {}
+
+impl Decimal128 {
+ pub fn new_from_bytes(precision: usize, scale: usize, bytes: &[u8]) -> Self {
+ let as_array = bytes.try_into();
+ let value = match as_array {
+ Ok(v) if bytes.len() == 16 => i128::from_le_bytes(v),
+ _ => panic!("Input to Decimal128 is not 128bit integer."),
Review Comment:
Wouldn't it be better to return a `Result` instead of `panic`-ing here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r898665800
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+/// Represents a decimal value with precision and scale.
+/// The decimal value is represented by a signed 128-bit integer.
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.eq(&other.value)
+ }
+}
+
+impl Eq for Decimal128 {}
+
+impl Decimal128 {
Review Comment:
`Decimal(p, s)`? We can have it. Because it is easy to add API but harder to remove. The API starts from minimalism. Currently I keep it as less as possible only to be on par with existing functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r898657340
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+/// Represents a decimal value with precision and scale.
+/// The decimal value is represented by a signed 128-bit integer.
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.eq(&other.value)
+ }
+}
+
+impl Eq for Decimal128 {}
+
+impl Decimal128 {
Review Comment:
Do we need a function to get the type of the decimal128 value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r897732642
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
Review Comment:
Perhaps a doc comment or something
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.eq(&other.value)
+ }
+}
+
+impl Eq for Decimal128 {}
+
+impl Decimal128 {
+ pub fn new_from_bytes(precision: usize, scale: usize, bytes: &[u8]) -> Self {
+ let as_array = bytes.try_into();
+ let value = match as_array {
+ Ok(v) if bytes.len() == 16 => i128::from_le_bytes(v),
+ _ => panic!("Input to Decimal128 is not 128bit integer."),
+ };
+
+ Decimal128 {
+ precision,
+ scale,
+ value,
+ }
+ }
+
+ pub fn new_from_i128(precision: usize, scale: usize, value: i128) -> Self {
Review Comment:
I'm presuming we will want to make Decimal256 and Decimal128 generic versions of the same impl, and so I wonder how methods like this which explicitly name the type will translate? Maybe new_from_raw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya merged PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r898656810
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
Review Comment:
I think the `assert` is needed.
If two decimal128 has diff type(precision or scale), we can't compare the value of i128.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#issuecomment-1157197892
> @viirya a question which is not about this pr. How to represent decimal256 in rust？How does c++ implement it? I'm not familiar with arrow c++ version.
Like C++ Arrow Decimal256, we can represent the integer in an array of parts of it. C++ Arrow Decimal256 uses an uint64_t array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r896426518
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
Review Comment:
I'm a bit not sure about comparing Decimal128. Although C++ Decimal128 just compares two uint64 values. We also compare i128 directly currently (e.g., ord kernel).
But I'm still wondering it is correct to compare two values with different scale? E.g., 100_i128 (scale 2) and 100_i128 (scale 3)? Isn't it "1.00" and "0.100" respectively?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#issuecomment-1157147689
I want to take a look this pr, please hold it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#issuecomment-1157189992
@viirya
a question which is not about this pr.
How to represent decimal256 in rust？How does c++ implement it?
I'm not familiar with arrow c++ version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#issuecomment-1154757340
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1871](https://codecov.io/gh/apache/arrow-rs/pull/1871?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (946e9d4) into [master](https://codecov.io/gh/apache/arrow-rs/commit/cedaf8a6ab55826c34f3b1bc9a21dbaf3e0328bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cedaf8a) will **decrease** coverage by `0.00%`.
> The diff coverage is `88.23%`.
```diff
@@ Coverage Diff @@
## master #1871 +/- ##
==========================================
- Coverage 83.46% 83.45% -0.01%
==========================================
Files 201 202 +1
Lines 57014 57069 +55
==========================================
+ Hits 47586 47627 +41
- Misses 9428 9442 +14
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/util/decimal.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvZGVjaW1hbC5ycw==) | `75.51% <75.51%> (ø)` | |
| [arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2JpbmFyeS5ycw==) | `94.18% <100.00%> (-0.06%)` | :arrow_down: |
| [arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIucnM=) | `86.98% <100.00%> (+0.09%)` | :arrow_up: |
| [arrow/src/array/equal\_json.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsX2pzb24ucnM=) | `89.70% <100.00%> (ø)` | |
| [arrow/src/array/iterator.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2l0ZXJhdG9yLnJz) | `96.11% <100.00%> (ø)` | |
| [arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jYXN0LnJz) | `95.77% <100.00%> (ø)` | |
| [arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9zb3J0LnJz) | `95.67% <100.00%> (ø)` | |
| [arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy90YWtlLnJz) | `95.27% <100.00%> (ø)` | |
| [parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfcmVhZGVyLnJz) | `96.87% <100.00%> (ø)` | |
| [parquet/src/arrow/arrow\_writer/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyL21vZC5ycw==) | `97.53% <100.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/arrow-rs/pull/1871/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1871?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1871?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cedaf8a...946e9d4](https://codecov.io/gh/apache/arrow-rs/pull/1871?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#discussion_r896426518
##########
arrow/src/util/decimal.rs:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Decimal related utils
+
+use std::cmp::Ordering;
+
+#[derive(Debug)]
+pub struct Decimal128 {
+ #[allow(dead_code)]
+ precision: usize,
+ scale: usize,
+ value: i128,
+}
+
+impl PartialOrd for Decimal128 {
+ fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Ord for Decimal128 {
+ fn cmp(&self, other: &Self) -> Ordering {
+ assert_eq!(
+ self.scale, other.scale,
+ "Cannot compare two Decimal128 with different scale: {}, {}",
+ self.scale, other.scale
+ );
+ self.value.cmp(&other.value)
+ }
+}
+
+impl PartialEq<Self> for Decimal128 {
+ fn eq(&self, other: &Self) -> bool {
Review Comment:
I'm a bit not sure about comparing Decimal128. Although C++ Decimal128 just compares two uint64 values. We also compare i128 directly currently (e.g., ord kernel).
But I'm still wondering it is correct to compare two values with different scale? E.g., 100_i128 (scale 2) and 100_i128 (scale 3)? Isn't it "1.00" and "0.100" respectively?
So I put an assert to check scale here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1871: Add Decimal128 API and use it in DecimalArray and DecimalBuilder
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1871:
URL: https://github.com/apache/arrow-rs/pull/1871#issuecomment-1157282099
Thank you @tustvold @liukun4515. I'm merging this and keeping working on Decimal256 and generalise them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org