[GitHub] rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181340774
 
 

 ##########
 File path: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
 ##########
 @@ -1246,8 +1246,7 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
 
         Map<String, String> configs = _configDao.getConfiguration("management-server", params);
 
-        String value = configs.get(Config.ConsoleProxyCmdPort.key());
-        value = configs.get("consoleproxy.sslEnabled");
+        String value = configs.get("consoleproxy.sslEnabled");
         if (value != null && value.equalsIgnoreCase("true")) {
 
 Review comment:
   You can use `org.apache.commons.lang3.BooleanUtils.toBoolean(String)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services