[GitHub] [hadoop-ozone] elek commented on a change in pull request #871: HDDS-3487. Ozone start fails with NullPointerException in TLS enabled cluster

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #871:
URL: https://github.com/apache/hadoop-ozone/pull/871#discussion_r415769570



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/LegacyHadoopConfigurationSource.java
##########
@@ -39,6 +40,11 @@ public String get(String key) {
     return configuration.getRaw(key);
   }
 
+  @Override
+  public char[] getPassword(String key) throws IOException {

Review comment:
       Long-term we might need a `getPassword()` for `ConfigurationSource` and we can have different implementations (with Hadoop Configuration we can use `CredentialProviders`, with different `ConfigurationSource` we can have different approaches). 
   
   Currently we have a very naive approach for `ConfigurationSource` we read the value as is, but using `getPassword` instead of `get` shows that we need an encryption. 
   
   But as of know getPassword() is not called only when we use Hadoop Configuration. Agree, we can remove it temporary, until we clean-up the HTTP utilities and switch to use full `Configuration`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org