Re: [PR] feat(country-map): redesign with worldview selection, Admin 0/1 support [SIP draft] [superset]

["sha174n (via GitHub)" <gi...@apache.org>]

sha174n commented on PR #40078:
URL: https://github.com/apache/superset/pull/40078#issuecomment-5281444379

   Structure looks right for a SIP POC — the ~20k lines are overwhelmingly generated geo data plus a reproducible build.py/mapshaper pipeline, with the actual code (CountryMap.tsx, controlPanel.tsx, build.py) staying modest, and the render path uses createElementNS/appendChild rather than innerHTML. Main thing to settle before it leaves draft: checking in both the generated GeoJSON and the build pipeline duplicates the source of truth — worth deciding whether the assets are committed artifacts or CI-built (the regen workflow suggests the latter) so they don't drift. Otherwise this reads as land-the-SIP-discussion-first.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org