You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "NicGrimpe (via GitHub)" <gi...@apache.org> on 2024/08/09 18:10:10 UTC
[PR] fix stm32wl5_rcc.h: Add the missing argument to RCC_PLLCFG_PLLP define. [nuttx]
NicGrimpe opened a new pull request, #12874:
URL: https://github.com/apache/nuttx/pull/12874
## Summary
The RCC_PLLCFG_PLLP define was missing an argument in it's definition.
## Impact
Would not compile if STM32WL5_PLLCFG_PLLP_ENABLED was set on stm32wl5 architecture.
## Testing
Built and ran on a board with a stm32wl5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix stm32wl5_rcc.h: Add the missing argument to RCC_PLLCFG_PLLP define. [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12874:
URL: https://github.com/apache/nuttx/pull/12874#discussion_r1712039491
##########
arch/arm/src/stm32wl5/hardware/stm32wl5_rcc.h:
##########
@@ -276,7 +276,7 @@
#define RCC_PLLCFG_PLLP_SHIFT (17) /* Bit 17-21: Main PLL div factor for PLLPCLK */
#define RCC_PLLCFG_PLLP_MASK (0x1f << RCC_PLLCFG_PLLP_SHIFT)
-# define RCC_PLLCFG_PLLP (((n)-1) << RCC_PLLCFG_PLLP_SHIFT) /* 2..32 */
+#define RCC_PLLCFG_PLLP(n) (((n)-1) << RCC_PLLCFG_PLLP_SHIFT) /* 2..32 */
Review Comment:
@NicGrimpe could you please align the "(((n..." to start exactly under the "(" from previous line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix stm32wl5_rcc.h: Add the missing argument to RCC_PLLCFG_PLLP define. [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12874:
URL: https://github.com/apache/nuttx/pull/12874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org